michael-o opened a new pull request, #99: URL: https://github.com/apache/maven-doxia/pull/99 Completely handle section handling which will now consistently apply between h1 and h5 for HTML and for Markdown. The partially unused or incorrectly mapped section h6 has been dropped. This closes #99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org
bertysentry commented on PR #99: URL: https://github.com/apache/maven-doxia/pull/99#issuecomment-1139116444 > @bertysentry Have a look at [apache/maven-doxia-sitetools@b002a41](https://github.com/apache/maven-doxia-sitetools/commit/b002a410296a248074eccd3a3af95b0ff7d697af). Ha ha! Must have been a lot of fun to update all these! To me everything looks in order. You updated the *Parser* classes to be consistent with the *Sink* classes, that's even better than what I first suggested. You still need to check the **maven-site-plugin** integration tests. This is a nice change, well done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org
michael-o commented on PR #99: URL: https://github.com/apache/maven-doxia/pull/99#issuecomment-1139110134 @bertysentry Have a look at https://github.com/apache/maven-doxia-sitetools/commit/b002a410296a248074eccd3a3af95b0ff7d697af. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org
michael-o commented on PR #99: URL: https://github.com/apache/maven-doxia/pull/99#issuecomment-1139108257 I have a followup branch for DOXIASITETOOLS ready locally. Please carefully look whether this is complete or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org
asfgit closed pull request #99: [DOXIA-619] Sink.sectionTitle1() creates <h2> instead of <h1> URL: https://github.com/apache/maven-doxia/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org
michael-o commented on PR #99:
URL: https://github.com/apache/maven-doxia/pull/99#issuecomment-1139117634
> > @bertysentry Have a look at [apache/maven-doxia-sitetools@b002a41](https://github.com/apache/maven-doxia-sitetools/commit/b002a410296a248074eccd3a3af95b0ff7d697af).
>
> Ha ha! Must have been a lot of fun to update all these! To me everything looks in order.
Yep, stupid trial and error.
> You updated the _Parser_ classes to be consistent with the _Sink_ classes, that's even better than what I first suggested. You still need to check the **maven-site-plugin** integration tests.
Yes, it strive for consistency and don't like surprises. Actually, I did run all MSITE ITs, they all pass. I have a local branch prepared with MSITE 4.x and upcoming Doxia/Doxia Sitetools. I do test the entire chain.
> This is a nice change, well done!
Thanks! Waiting for @hboutemy to go through as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org