You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/15 23:28:07 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19357: [TEST] Added large tensor tests to verify support for split ops
access2rohit opened a new pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357
Large tensor tests for `split`, `hsplit`, `vsplit` and `dsplit`
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
- [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [X] All changes have test coverage
- [X] Code is well-documented
### Testing ###
will update in a while
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#discussion_r505927937
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2001,3 +2001,66 @@ def test_vstack():
assert out2[0, -1] == 0 and out2[1, -1] == 1
assert inp2.grad.shape == inp2.shape
assert inp2.grad[-1, -1] == 1
+
+
+@use_np
+def test_split():
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[INT_OVERFLOW // 2] = 2
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.split(inp, 2, axis = 0)
+ out[1].backward()
+ assert out[0].shape == (INT_OVERFLOW // 2, 2)
+ assert out[1].shape == (INT_OVERFLOW // 2, 2)
+ assert out[0][0, 0] == 1
+ assert out[1][0, 0] == 2
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_hsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.hsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW, 2)
+ assert out[0].shape == (INT_OVERFLOW, 2)
+ assert out[1][-1][0] == INT_OVERFLOW-1
+ assert out[0][-1][1] == INT_OVERFLOW-1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_vsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.vsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW//2, 4)
+ assert out[0].shape == (INT_OVERFLOW//2, 4)
+ assert out[0][-1][0] == INT_OVERFLOW // 2 -1
+ assert out[1][-1][1] == INT_OVERFLOW - 1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[INT_OVERFLOW//2 - 1][-1] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_dsplit():
+ inp = np.arange(INT_OVERFLOW, dtype=np.int64).reshape(INT_OVERFLOW, 1, 1)
Review comment:
use create_2d_np_tensor here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#discussion_r505935438
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2001,3 +2001,66 @@ def test_vstack():
assert out2[0, -1] == 0 and out2[1, -1] == 1
assert inp2.grad.shape == inp2.shape
assert inp2.grad[-1, -1] == 1
+
+
+@use_np
+def test_split():
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[INT_OVERFLOW // 2] = 2
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.split(inp, 2, axis = 0)
+ out[1].backward()
+ assert out[0].shape == (INT_OVERFLOW // 2, 2)
+ assert out[1].shape == (INT_OVERFLOW // 2, 2)
+ assert out[0][0, 0] == 1
+ assert out[1][0, 0] == 2
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_hsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.hsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW, 2)
+ assert out[0].shape == (INT_OVERFLOW, 2)
+ assert out[1][-1][0] == INT_OVERFLOW-1
+ assert out[0][-1][1] == INT_OVERFLOW-1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_vsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.vsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW//2, 4)
+ assert out[0].shape == (INT_OVERFLOW//2, 4)
+ assert out[0][-1][0] == INT_OVERFLOW // 2 -1
+ assert out[1][-1][1] == INT_OVERFLOW - 1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[INT_OVERFLOW//2 - 1][-1] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_dsplit():
+ inp = np.arange(INT_OVERFLOW, dtype=np.int64).reshape(INT_OVERFLOW, 1, 1)
Review comment:
ohh ok that makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#discussion_r505934901
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2001,3 +2001,66 @@ def test_vstack():
assert out2[0, -1] == 0 and out2[1, -1] == 1
assert inp2.grad.shape == inp2.shape
assert inp2.grad[-1, -1] == 1
+
+
+@use_np
+def test_split():
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[INT_OVERFLOW // 2] = 2
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.split(inp, 2, axis = 0)
+ out[1].backward()
+ assert out[0].shape == (INT_OVERFLOW // 2, 2)
+ assert out[1].shape == (INT_OVERFLOW // 2, 2)
+ assert out[0][0, 0] == 1
+ assert out[1][0, 0] == 2
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_hsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.hsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW, 2)
+ assert out[0].shape == (INT_OVERFLOW, 2)
+ assert out[1][-1][0] == INT_OVERFLOW-1
+ assert out[0][-1][1] == INT_OVERFLOW-1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_vsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.vsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW//2, 4)
+ assert out[0].shape == (INT_OVERFLOW//2, 4)
+ assert out[0][-1][0] == INT_OVERFLOW // 2 -1
+ assert out[1][-1][1] == INT_OVERFLOW - 1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[INT_OVERFLOW//2 - 1][-1] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_dsplit():
+ inp = np.arange(INT_OVERFLOW, dtype=np.int64).reshape(INT_OVERFLOW, 1, 1)
Review comment:
this is 3d now. We don't have N-Dim function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#issuecomment-709645303
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#discussion_r505934901
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2001,3 +2001,66 @@ def test_vstack():
assert out2[0, -1] == 0 and out2[1, -1] == 1
assert inp2.grad.shape == inp2.shape
assert inp2.grad[-1, -1] == 1
+
+
+@use_np
+def test_split():
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[INT_OVERFLOW // 2] = 2
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.split(inp, 2, axis = 0)
+ out[1].backward()
+ assert out[0].shape == (INT_OVERFLOW // 2, 2)
+ assert out[1].shape == (INT_OVERFLOW // 2, 2)
+ assert out[0][0, 0] == 1
+ assert out[1][0, 0] == 2
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_hsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.hsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW, 2)
+ assert out[0].shape == (INT_OVERFLOW, 2)
+ assert out[1][-1][0] == INT_OVERFLOW-1
+ assert out[0][-1][1] == INT_OVERFLOW-1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_vsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.vsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW//2, 4)
+ assert out[0].shape == (INT_OVERFLOW//2, 4)
+ assert out[0][-1][0] == INT_OVERFLOW // 2 -1
+ assert out[1][-1][1] == INT_OVERFLOW - 1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[INT_OVERFLOW//2 - 1][-1] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_dsplit():
+ inp = np.arange(INT_OVERFLOW, dtype=np.int64).reshape(INT_OVERFLOW, 1, 1)
Review comment:
this is 3d now. We don't have N-Dim function. PLus not too many cases where we need 3d tensor for testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#discussion_r505934901
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2001,3 +2001,66 @@ def test_vstack():
assert out2[0, -1] == 0 and out2[1, -1] == 1
assert inp2.grad.shape == inp2.shape
assert inp2.grad[-1, -1] == 1
+
+
+@use_np
+def test_split():
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[INT_OVERFLOW // 2] = 2
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.split(inp, 2, axis = 0)
+ out[1].backward()
+ assert out[0].shape == (INT_OVERFLOW // 2, 2)
+ assert out[1].shape == (INT_OVERFLOW // 2, 2)
+ assert out[0][0, 0] == 1
+ assert out[1][0, 0] == 2
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_hsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.hsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW, 2)
+ assert out[0].shape == (INT_OVERFLOW, 2)
+ assert out[1][-1][0] == INT_OVERFLOW-1
+ assert out[0][-1][1] == INT_OVERFLOW-1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[0][0] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_vsplit():
+ inp = create_2d_np_tensor(rows=INT_OVERFLOW, columns=4)
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.vsplit(inp, 2)
+ out[1].backward()
+ assert out[1].shape == (INT_OVERFLOW//2, 4)
+ assert out[0].shape == (INT_OVERFLOW//2, 4)
+ assert out[0][-1][0] == INT_OVERFLOW // 2 -1
+ assert out[1][-1][1] == INT_OVERFLOW - 1
+ assert inp.grad.shape == inp.shape
+ assert inp.grad[INT_OVERFLOW//2 - 1][-1] == 0 and inp.grad[-1][-1] == 1
+
+
+@use_np
+def test_dsplit():
+ inp = np.arange(INT_OVERFLOW, dtype=np.int64).reshape(INT_OVERFLOW, 1, 1)
Review comment:
This is 3d tensor. We don't have N-Dim function. Plus not too many cases where we need 3d tensor for testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19357: [TEST] Added large tensor tests to verify support for split ops
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19357:
URL: https://github.com/apache/incubator-mxnet/pull/19357#issuecomment-709641857
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, sanity, clang, website, windows-cpu, miscellaneous, centos-cpu, unix-cpu, edge, centos-gpu, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org