[GitHub] [calcite] chunweilei commented on a change in pull request #1652: [CALCITE-3599] Initial the digest of RexRangeRef to avoid null string

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1652: [CALCITE-3599] Initial the digest of RexRangeRef to avoid null string
URL: https://github.com/apache/calcite/pull/1652#discussion_r357233772
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexRangeRef.java
 ##########
 @@ -57,6 +57,7 @@
       int offset) {
     this.type = rangeType;
     this.offset = offset;
+    this.digest = "offset(" + offset + ")";
   }
 
 
 Review comment:
   This class is used only during the process of translating a SqlNode to RelNode. So it is hard to add a test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services