You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/03 09:04:41 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1542: Correct hyperlinks in GitHub templates
TeslaCN opened a new pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on pull request #1542: Correct hyperlinks in GitHub templates
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542#issuecomment-703114649
cc @terrymanu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN closed pull request #1542: Correct hyperlinks in GitHub templates
Posted by GitBox <gi...@apache.org>.
TeslaCN closed pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on a change in pull request #1542: Correct hyperlinks in GitHub templates
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542#discussion_r499153743
##########
File path: .github/workflows/maven.yml
##########
@@ -29,7 +29,7 @@ on:
jobs:
build:
- runs-on: macos-latest
+ runs-on: ubuntu-latest
Review comment:
I'm not sure about this. Shardingsphere uses macos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1542: Correct hyperlinks in GitHub templates
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542#discussion_r499154254
##########
File path: .github/workflows/maven.yml
##########
@@ -29,7 +29,7 @@ on:
jobs:
build:
- runs-on: macos-latest
+ runs-on: ubuntu-latest
Review comment:
I think Linux is more common in actual environment and it is a little faster than macOS in GitHub Action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1542: Correct hyperlinks in GitHub templates
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542#discussion_r499154254
##########
File path: .github/workflows/maven.yml
##########
@@ -29,7 +29,7 @@ on:
jobs:
build:
- runs-on: macos-latest
+ runs-on: ubuntu-latest
Review comment:
I think Linux is more common in actual environment and it is a little faster than macOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1542: Correct hyperlinks in GitHub templates
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1542:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1542#issuecomment-703116029
I'm going to separate the commits in different PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org