You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "fachhoch (JIRA)" <ji...@apache.org> on 2011/07/13 15:50:59 UTC

[jira] [Created] (WICKET-3895) :Close connection

:Close connection
-----------------

                 Key: WICKET-3895
                 URL: https://issues.apache.org/jira/browse/WICKET-3895
             Project: Wicket
          Issue Type: Improvement
          Components: wicket-core
    Affects Versions: 1.4.12
         Environment: any
            Reporter: fachhoch
            Priority: Minor


Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-3895) :Close connection

Posted by "fachhoch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064565#comment-13064565 ] 

fachhoch commented on WICKET-3895:
----------------------------------

I faced this issue  with  1.4.12 I did not try with 1.5.

> :Close connection
> -----------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Priority: Minor
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-3895) :Close connection

Posted by "fachhoch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064576#comment-13064576 ] 

fachhoch commented on WICKET-3895:
----------------------------------

link   to  discussion

http://apache-wicket.1842946.n4.nabble.com/exception-no-clue-for-the-cause-td3646873.html#a3646914

> :Close connection
> -----------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Priority: Minor
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-3895) :Close connection

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064567#comment-13064567 ] 

Martin Grigorov commented on WICKET-3895:
-----------------------------------------

Which issue ?
Last week someone had an issue with WebLogic server and NullPointerException in one of its impls but I don't remember the user who complained about it.
If this is you then please paste the stacktrace again or link the ticket to the mail discussion.  

> :Close connection
> -----------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Priority: Minor
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-3895) :Close connection

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064557#comment-13064557 ] 

Martin Grigorov commented on WICKET-3895:
-----------------------------------------

Do you have specific code in mind or this requirement is general ?
Wicket 1.5 is improved in this area compared to 1.4 (especially 1.4.12).

> :Close connection
> -----------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Priority: Minor
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WICKET-3895) Ignore the exception when closing a connection used to get the resource last modification time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3895.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC6
                   1.4.18

> Ignore the exception when closing a connection used to get the resource last modification time
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.4.18, 1.5-RC6
>
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-3895) Ignore the exception when closing a connection used to get the resource last modification time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-3895:
------------------------------------

    Assignee: Martin Grigorov
     Summary: Ignore the exception when closing a connection used to get the resource last modification time  (was: :Close connection)

> Ignore the exception when closing a connection used to get the resource last modification time
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-3895) :Close connection

Posted by "fachhoch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064575#comment-13064575 ] 

fachhoch commented on WICKET-3895:
----------------------------------

here is the stack trace 


java.lang.NullPointerException
	at java.io.FilterInputStream.close(FilterInputStream.java:155)
	at weblogic.utils.zip.SafeZipFileInputStream.close(SafeZipFileInputStream.java:37)
	at org.apache.wicket.util.io.Connections.close(Connections.java:113)
	at org.apache.wicket.util.io.Connections.getLastModified(Connections.java:73)
	at org.apache.wicket.util.resource.UrlResourceStream.lastModifiedTime(UrlResourceStream.java:223)
	at org.apache.wicket.markup.html.PackageResource.getResourceStream(PackageResource.java:607)
	at org.apache.wicket.markup.html.PackageResource.getResourceStream(PackageResource.java:565)
	at org.apache.wicket.Resource.init(Resource.java:213)
	at org.apache.wicket.Resource.onResourceRequested(Resource.java:117)
	at org.apache.wicket.request.target.resource.SharedResourceRequestTarget.respond(SharedResourceRequestTarget.java:213)
	at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
	at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
	at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
	at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1436)
	at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
	at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:484)
	at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:317)
	at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:56)
	at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:265)
	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
	at org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:275)
	at org.acegisecurity.util.FilterChainProxy.doFilter(FilterChainProxy.java:149)
	at org.acegisecurity.util.FilterToBeanProxy.doFilter(FilterToBeanProxy.java:98)
	at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:56)
	at org.springframework.orm.hibernate3.support.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:198)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
	at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:56)
	at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.doIt(WebAppServletContext.java:3684)
	at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:3650)
	at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321)
	at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121)
	at weblogic.servlet.internal.WebAppServletContext.securedExecute(WebAppServletContext.java:2268)
	at weblogic.servlet.internal.WebAppServletContext.execute(WebAppServletContext.java:2174)
	at weblogic.servlet.internal.ServletRequestImpl.run(ServletRequestImpl.java:1446)
	at weblogic.work.ExecuteThread.execute(ExecuteThread.java:201)
	at weblogic.work.ExecuteThread.run(ExecuteThread.java:173)

> :Close connection
> -----------------
>
>                 Key: WICKET-3895
>                 URL: https://issues.apache.org/jira/browse/WICKET-3895
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.12
>         Environment: any
>            Reporter: fachhoch
>            Priority: Minor
>
> Wicket can improve  by using Connections.closeQuietly()  instead of #close(). This way even if the closing fail at least the  request will continue its processing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira