You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li...@apache.org on 2008/02/21 03:15:38 UTC
svn commit: r629674 - /incubator/shindig/trunk/features/rpc/rpc.js
Author: lindner
Date: Wed Feb 20 18:15:30 2008
New Revision: 629674
URL: http://svn.apache.org/viewvc?rev=629674&view=rev
Log:
Fix bug with Firefox 3, rpcData wasn't getting initialized
Modified:
incubator/shindig/trunk/features/rpc/rpc.js
Modified: incubator/shindig/trunk/features/rpc/rpc.js
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?rev=629674&r1=629673&r2=629674&view=diff
==============================================================================
--- incubator/shindig/trunk/features/rpc/rpc.js (original)
+++ incubator/shindig/trunk/features/rpc/rpc.js Wed Feb 20 18:15:30 2008
@@ -217,6 +217,13 @@
} else {
from = '..';
}
+ // Not used by legacy, create it anyway...
+ var rpcData = gadgets.json.stringify({
+ s: serviceName,
+ f: from,
+ c: callback ? callId : 0,
+ a: Array.prototype.slice.call(arguments, 3)
+ });
switch (relayChannel) {
case 'dpm': // use document.postMessage
@@ -240,12 +247,6 @@
src = [relay, '#', encodeLegacyData([from, '&', callId, '&1&0&',
encodeLegacyData(legacyData)])].join('');
} else {
- var rpcData = gadgets.json.stringify({
- s: serviceName,
- f: from,
- c: callback ? callId : 0,
- a: Array.prototype.slice.call(arguments, 3)
- });
// # targetId & sourceId@callId & packetNum & packetId & packetData
src = [relay, '#', targetId, '&', from, '@', callId,
'&1&0&', rpcData].join('');
Re: svn commit: r629674 - /incubator/shindig/trunk/features/rpc/rpc.js
Posted by Kevin Brown <et...@google.com>.
I'm running FF3 nightly and this doesn't appear to be an issue. What are you
running? Is this a known issue to mozilla? If this bug shows up somewhere it
would break a lot of other things.
On Wed, Feb 20, 2008 at 6:15 PM, <li...@apache.org> wrote:
> Author: lindner
> Date: Wed Feb 20 18:15:30 2008
> New Revision: 629674
>
> URL: http://svn.apache.org/viewvc?rev=629674&view=rev
> Log:
> Fix bug with Firefox 3, rpcData wasn't getting initialized
>
> Modified:
> incubator/shindig/trunk/features/rpc/rpc.js
>
> Modified: incubator/shindig/trunk/features/rpc/rpc.js
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?rev=629674&r1=629673&r2=629674&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/rpc/rpc.js (original)
> +++ incubator/shindig/trunk/features/rpc/rpc.js Wed Feb 20 18:15:30 2008
> @@ -217,6 +217,13 @@
> } else {
> from = '..';
> }
> + // Not used by legacy, create it anyway...
> + var rpcData = gadgets.json.stringify({
> + s: serviceName,
> + f: from,
> + c: callback ? callId : 0,
> + a: Array.prototype.slice.call(arguments, 3)
> + });
>
> switch (relayChannel) {
> case 'dpm': // use document.postMessage
> @@ -240,12 +247,6 @@
> src = [relay, '#', encodeLegacyData([from, '&', callId, '&1&0&',
> encodeLegacyData(legacyData)])].join('');
> } else {
> - var rpcData = gadgets.json.stringify({
> - s: serviceName,
> - f: from,
> - c: callback ? callId : 0,
> - a: Array.prototype.slice.call(arguments, 3)
> - });
> // # targetId & sourceId@callId & packetNum & packetId &
> packetData
> src = [relay, '#', targetId, '&', from, '@', callId,
> '&1&0&', rpcData].join('');
>
>
>
--
~Kevin
If you received this email by mistake, please delete it, cancel your mail
account, destroy your hard drive, silence any witnesses, and burn down the
building that you're in.