[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6483: [ISSUE #6482]style: Rename the variable "filepath" to "filePath" on line 55 of PosixFileSegment.java

["ShadowySpirits (via GitHub)" <gi...@apache.org>]

ShadowySpirits commented on code in PR #6483:
URL: https://github.com/apache/rocketmq/pull/6483#discussion_r1149143324


##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/posix/PosixFileSegment.java:
##########
@@ -52,7 +52,7 @@ public class PosixFileSegment extends TieredFileSegment {
     private static final String OPERATION_POSIX_WRITE = "write";
 
     private final String basePath;
-    private final String filepath;
+    private final String filePath;

Review Comment:
   There is no need to make changes as "filepath" is widely used in many libraries, including the [Go standard library](https://pkg.go.dev/path/filepath). There has been a lot of discussion regarding the usage of "filepath" and "file path". As an example, I would like to quote one such discussion below.
   
   
   > filepath, as an unhyphenated compound word, is generally used when discussing it as an entity (e.g., “You’ll need to set the filepath before writing out any data.”), but file path, as two words, is generally used when referring to a particular attribute of a file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org