You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:54:36 UTC

[GitHub] [arrow-rs] alamb commented on pull request #1767: Remove `validate_decimal_precision` check in `DecimalBuilder.append_value`

alamb commented on PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#issuecomment-1142035936

   > In one way, as we don't do full validation when finishing the builder, it seems this check is necessary if it is the promise of the builder to always build a valid ArrayData. Then the check is needed and it seems C++ needs to add the check there. I will open a ticket there and try to get some feedbacks.
   
   I think this is the right thing to do -- thank you @viirya 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org