You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/08/07 19:14:52 UTC

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r467223869



##########
File path: cppcache/src/ExceptionTypes.cpp
##########
@@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();
       PutAllPartialResultException ex(message);
       throw ex;
     }
-    default: {
+    case GF_NOERR:

Review comment:
       ![pdxcodemonkey?](http://media2.giphy.com/gifsu/1qbj0e6kDAjS7elwu0/giphy-caption.gif?cid=6104955e5f2b035851577a4b4d4cc90a)
   
   (I mostly just wanted to post that gif, no particular rush 😃)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org