[GitHub] [hive] asolimando commented on a diff in pull request #3592: HIVE-25848 Empty result for structs in point lookup optimization with…

[GitBox <gi...@apache.org>]

asolimando commented on code in PR #3592:
URL: https://github.com/apache/hive/pull/3592#discussion_r973553873


##########
ql/src/test/queries/clientpositive/vector_struct_in2.q:
##########
@@ -0,0 +1,22 @@
+set hive.fetch.task.conversion=none;
+
+create table test (a string) partitioned by (y string, m string);
+insert into test values ('aa', 2022, 9);
+
+--original bug report
+select * from test where (y=year(date_sub('2022-09-11',4)) and m=month(date_sub('2022-09-11',4))) or (y=year(date_sub('2022-09-11',10)) and m=month(date_sub('2022-09-11',10)) );
+
+set hive.optimize.point.lookup=false;

Review Comment:
   Why do you need to set these to false in the test? From the case description the original bug is not hit when either of the two is disabled, aren't we undermining the test in this way?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org