[jira] [Commented] (IMPALA-8360) SynchronousThreadPoolTest ASSERT_TRUE(*no_sleep_destroyed) failed

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810965#comment-16810965 ] 

ASF subversion and git services commented on IMPALA-8360:
---------------------------------------------------------

Commit 80b82b5b2c60ff934eabe42dd145c9f84ca3a60b in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=80b82b5 ]

IMPALA-8360: Fix race conditions in thread-pool-test

There are race conditions in thread-pool-test between the caller
thread and the worker thread. Specifically, in some cases, the
worker thread seems to be slow in freeing resources. This can
lead to asserts failing because the work item has not been
freed or because the submit of a task failed when it should
not have.

This fixes the race conditions:
 - It breaks up the existing SynchronousThreadPoolTest into two
   smaller tests so that the two can't interfere with each other.
 - It adds the ability to sleep and recheck that the work item
   has been freed.

Testing:
 - Ran thread-pool-test in a loop for 20k iterations

Change-Id: Id2d5f8b677e475d8e9d6b4512e990b20bfbefaf1
Reviewed-on: http://gerrit.cloudera.org:8080/12916
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> SynchronousThreadPoolTest ASSERT_TRUE(*no_sleep_destroyed) failed
> -----------------------------------------------------------------
>
>                 Key: IMPALA-8360
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8360
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Sahil Takiar
>            Assignee: Joe McDonnell
>            Priority: Major
>              Labels: broken-build
>
> Jenkins output:
> {code}
> Error Message
> Value of: *no_sleep_destroyed   Actual: false Expected: true
> Stacktrace
> /data/jenkins/workspace/impala-cdh6.x-core-data-load/repos/Impala/be/src/util/thread-pool-test.cc:112
> Value of: *no_sleep_destroyed
>   Actual: false
> Expected: true
> {code}
> Seen once on Centos 7 during a core-data-load.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org