You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "luckylsk34 (via GitHub)" <gi...@apache.org> on 2023/02/20 16:55:36 UTC
[GitHub] [arrow-ballista] luckylsk34 opened a new pull request, #679: Allow `BallistaContext::read_*` methods to read multiple paths.
luckylsk34 opened a new pull request, #679:
URL: https://github.com/apache/arrow-ballista/pull/679
# Which issue does this PR close?
Closes #584 #587.
# Rationale for this change
Add the ability to read multiple files using `read_*` methods.
# What changes are included in this PR?
1. Added `read_json` method
2. Modified function signature to take any argument implementing `DataFilePaths` trait.
# Are there any user-facing changes?
Yes, they will be able to use `read_*` methods as follows: `read_csv(vec!["", ""])`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove merged pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#issuecomment-1439971454
LGTM. The changes seem consistent with recent changes in DataFusion. It looks like there are some build issues to be resolved. Thanks @luckylsk34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] saikrishna1-bidgely commented on a diff in pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "saikrishna1-bidgely (via GitHub)" <gi...@apache.org>.
saikrishna1-bidgely commented on code in PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#discussion_r1116901902
##########
ballista-cli/Cargo.toml:
##########
@@ -33,8 +33,8 @@ ballista = { path = "../ballista/client", version = "0.10.0", features = [
"standalone",
] }
clap = { version = "3", features = ["derive", "cargo"] }
-datafusion = "18.0.0"
-datafusion-cli = "18.0.0"
+datafusion = { git = "https://github.com/apache/arrow-datafusion" }
Review Comment:
added the specific revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] luckylsk34 commented on a diff in pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "luckylsk34 (via GitHub)" <gi...@apache.org>.
luckylsk34 commented on code in PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#discussion_r1116907394
##########
ballista-cli/Cargo.toml:
##########
@@ -33,8 +33,8 @@ ballista = { path = "../ballista/client", version = "0.10.0", features = [
"standalone",
] }
clap = { version = "3", features = ["derive", "cargo"] }
-datafusion = "18.0.0"
-datafusion-cli = "18.0.0"
+datafusion = { git = "https://github.com/apache/arrow-datafusion" }
Review Comment:
Done, added the specific revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#discussion_r1114281256
##########
ballista-cli/Cargo.toml:
##########
@@ -33,8 +33,8 @@ ballista = { path = "../ballista/client", version = "0.10.0", features = [
"standalone",
] }
clap = { version = "3", features = ["derive", "cargo"] }
-datafusion = "18.0.0"
-datafusion-cli = "18.0.0"
+datafusion = { git = "https://github.com/apache/arrow-datafusion" }
Review Comment:
Please pin to a specific rev here so that we have stable builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] luckylsk34 commented on pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "luckylsk34 (via GitHub)" <gi...@apache.org>.
luckylsk34 commented on PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#issuecomment-1443736384
@andygrove build is a success. Any more changes needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] luckylsk34 commented on pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "luckylsk34 (via GitHub)" <gi...@apache.org>.
luckylsk34 commented on PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#issuecomment-1437314961
@alamb @andygrove pls review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] luckylsk34 commented on pull request #679: Allow `BallistaContext::read_*` methods to read multiple paths.
Posted by "luckylsk34 (via GitHub)" <gi...@apache.org>.
luckylsk34 commented on PR #679:
URL: https://github.com/apache/arrow-ballista/pull/679#issuecomment-1443629279
@andygrove I've added the specific revision and fixed the conflicts, pls approve the workflows. Lets see if we again get the build issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org