You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/02 08:54:26 UTC
[GitHub] [flink] chucheng92 opened a new pull request, #21442: [FLINK-30274][pom] Add commons-collections4 to replace commons-collec…
chucheng92 opened a new pull request, #21442:
URL: https://github.com/apache/flink/pull/21442
## What is the purpose of the change
Apache commons-collections 3.x is a Java 1.3 compatible version, and it does not use Java 5 generics. Apache commons-collections4 4.4 is an upgraded version of commons-collections and it built by Java 8. Because the flink-core use commons-collections 3.x in some old codes, so we currently we can not upgrade it directly. This we add commons-collections4 support first in order to forbid the next and later error usages.
## Brief change log
Add commons-collections4 dependency in managed pom.
## Verifying this change
Just add dependency in managed pom, it will not cause build error. Verifying by CI process.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no (managed pom)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1449717547
@MartijnVisser PTAL:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1613131004
Hi, Martijn. thanks. it seems like a recent code introduced a old usage. I updated it.
please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422114983
@MartijnVisser PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on a diff in pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on code in PR #21442:
URL: https://github.com/apache/flink/pull/21442#discussion_r1248018536
##########
pom.xml:
##########
@@ -684,9 +684,9 @@ under the License.
<!-- commons collections needs to be pinned to this critical security fix version -->
<dependency>
- <groupId>commons-collections</groupId>
Review Comment:
@MartijnVisser hi, Martijn. If we can not fix it in flink-connector-kafka, can we solved it in flink here? not replace it, but add a dependency. when flink-connector-kafka update, check and remove it in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1482162760
@MartijnVisser thanks for explanations. make sense. we will be watching closely about kafka externalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21442: [FLINK-30274][pom] Add commons-collections4 to replace commons-collec…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1334947085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9d2b892794661394cec61ce664be31920648baf4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9d2b892794661394cec61ce664be31920648baf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9d2b892794661394cec61ce664be31920648baf4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21442: [FLINK-30274][pom] Add commons-collections4 to replace commons-collec…
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1334990431
Again, why would we add a dependency without using it? There's no value in that. Please change current usage of `commons-collections` to `commons-collections4`. Else there's no value in the PR and I'll have to close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1469359601
> hi. @MartijnVisser i have updated the pr. And i searched the source code didn't find any other occurs using `org.apache.commons.collections`. PTAL. thanks.
hi. @MartijnVisser please take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1424296845
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1423636231
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422113508
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422143809
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1429129569
@MartijnVisser I think we can fix it completely. i will fix this and update pr ASAP. Sorry for my mistake. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1612372450
@MartijnVisser hi, Martijn, https://issues.apache.org/jira/browse/FLINK-30859 has been resolved. Can you help me to check this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422205045
@MartijnVisser thanks. Is this caused by updating the commons-collections4? It add some transitive dependencies?
INFO org.apache.flink.tools.ci.licensecheck.NoticeFileChecker [] - Problems were detected for a NOTICE file.
flink-sql-connector-hbase-2.2:
These issues are assumed to be false-positives:
Dependency com.fasterxml.jackson.core:jackson-core:2.4.0 is not bundled, but listed.
Dependency com.google.protobuf:protobuf-java:3.7.1 is not bundled, but listed.
Dependency com.google.code.gson:gson:2.8.5 is not bundled, but listed.
Dependency com.fasterxml.jackson.core:jackson-databind:2.4.0 is not bundled, but listed.
Dependency com.fasterxml.jackson.core:jackson-annotations:2.4.0 is not bundled, but listed.
Dependency org.apache.commons:commons-collections4:4.3 is not bundled, but listed.
Dependency com.google.protobuf:protobuf-java-util:3.7.1 is not bundled, but listed.
Dependency commons-logging:commons-logging:1.1.1 is not bundled, but listed.
Dependency com.google.guava:guava:27.1-jre is not bundled, but listed.
Dependency com.google.guava:failureaccess:1.0.1 is not bundled, but listed.
Dependency io.netty:netty-all:4.1.34.Final is not bundled, but listed.
Dependency commons-cli:commons-cli:1.4 is not bundled, but listed.
Can we add a NOTICE file in flink-core to address this or temporarily we do not do this updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1614785397
@MartijnVisser There is a circular reference.
ci failed becase flink-python kafka test case failed.
<img width="1014" alt="image" src="https://github.com/apache/flink/assets/11287509/d12b60f4-7ff3-457e-a2c4-8cd415bb5ca2">
<img width="969" alt="image" src="https://github.com/apache/flink/assets/11287509/6b096a4f-83f0-4287-b7ad-d46b9371de4c">
flink-python test case reference flink-sql-connector-kafka. so we need update flink-sql-connector-kafka first.
The pr is: https://github.com/apache/flink-connector-kafka/pull/37, then this pr can merge, and finally we may remove explicit dependency in flink-connector-kafka. (or keep it remained.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on a diff in pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on code in PR #21442:
URL: https://github.com/apache/flink/pull/21442#discussion_r1248018536
##########
pom.xml:
##########
@@ -684,9 +684,9 @@ under the License.
<!-- commons collections needs to be pinned to this critical security fix version -->
<dependency>
- <groupId>commons-collections</groupId>
Review Comment:
@MartijnVisser hi, Martijn. If we can not fix it in flink-connector-kafka, can we solved it in flink here? not replace it, but add a dependency. when flink-connector-kafka update, check and remove it in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422103023
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422208203
> Is this caused by updating the commons-collections4?
Yes
> It add some transitive dependencies?
No. Like those lines say `These issues are assumed to be false-positives`.
The issue lies here https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=45877&view=logs&j=b59e5554-36c7-5512-ab1a-b80b74075fce&t=849d419c-1b8f-52b7-e455-d4bc36ec43ad&l=30273
```
flink-dist:
These issue are legally problematic and MUST be fixed:
Dependency org.apache.commons:commons-collections4:4.4 is not listed.
These issues are mistakes that aren't legally problematic. They SHOULD be fixed at some point, but we don't have to:
Dependency commons-collections:commons-collections:3.2.2 is not bundled, but listed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422222706
> > Is this caused by updating the commons-collections4?
>
> Yes
>
> > It add some transitive dependencies?
>
> No. Like those lines say `These issues are assumed to be false-positives`.
>
> The issue lies here https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=45877&view=logs&j=b59e5554-36c7-5512-ab1a-b80b74075fce&t=849d419c-1b8f-52b7-e455-d4bc36ec43ad&l=30273
>
> ```
> flink-dist:
> These issue are legally problematic and MUST be fixed:
> Dependency org.apache.commons:commons-collections4:4.4 is not listed.
> These issues are mistakes that aren't legally problematic. They SHOULD be fixed at some point, but we don't have to:
> Dependency commons-collections:commons-collections:3.2.2 is not bundled, but listed.
> ```
Can i update the commons-collections3 to commons-collections4 in NOTICE file?
- commons-collections:commons-collections:3.2.2 -> - org.apache.commons:commons-collections4:4.4
Do I just need to update the NOTICE file of the flink-dist module or do I need to update all the places where it appears?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1614578964
> please check.
The CI is failing for your PR. Please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422191233
> @MartijnVisser PTAL, thanks.
@chucheng92 The PR can't pass the CI because it doesn't contain the necessary changes to the NOTICE files (where's there's still an outdated reference to the previous versions of commons-collections and none to the new one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274][pom] Add commons-collections4 to replace commons-collec…
Posted by GitBox <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1334977375
> This is not a replacement, but just adding collections4 without using it. Where's the value in that?
>
> I would expect that a replacement also shows the refactoring of the current usage of `commons-collections` to `commons-collections4`.
Add it in dependencyManagement to let the submodules match with this version in later using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274][pom] Add commons-collections4 to replace commons-collec…
Posted by GitBox <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1335014296
> Again, why would we add a dependency without using it? There's no value in that. Please change current usage of `commons-collections` to `commons-collections4`. Else there's no value in the PR and I'll have to close it.
Yes. the best solution is replacing it. Can I open a new issue to refactor some old codes to replace it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1431082681
hi. @MartijnVisser i have updated the pr. And i searched the source code and didn't find any other occurs using `org.apache.commons.collections`. PTAL. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1425353481
@MartijnVisser thanks. i rebased it. ci passed. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1424327314
@chucheng92 You need to rebase your PR on the latest `master`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1422231796
> > Is this caused by updating the commons-collections4?
>
> Yes
>
> > It add some transitive dependencies?
>
> No. Like those lines say `These issues are assumed to be false-positives`.
>
> The issue lies here https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=45877&view=logs&j=b59e5554-36c7-5512-ab1a-b80b74075fce&t=849d419c-1b8f-52b7-e455-d4bc36ec43ad&l=30273
>
> ```
> flink-dist:
> These issue are legally problematic and MUST be fixed:
> Dependency org.apache.commons:commons-collections4:4.4 is not listed.
> These issues are mistakes that aren't legally problematic. They SHOULD be fixed at some point, but we don't have to:
> Dependency commons-collections:commons-collections:3.2.2 is not bundled, but listed.
> ```
i think i already know how to do it. [PR-21048](https://github.com/apache/flink/pull/21048) There is similar work done here. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Upgrade commons-collections 3.x to commons-collections4
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1430811070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org