You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/01/16 06:59:25 UTC

[17/17] james-project git commit: JAMES-2637 add test to MappingSource to be sure it matches the bean contract

JAMES-2637 add test to MappingSource to be sure it matches the bean contract


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/4cdfef08
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/4cdfef08
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/4cdfef08

Branch: refs/heads/master
Commit: 4cdfef08ac033b99e5c31e9dd4c53379ea568425
Parents: dcb093e
Author: Rene Cordier <rc...@linagora.com>
Authored: Tue Jan 15 17:37:13 2019 +0700
Committer: Benoit Tellier <bt...@linagora.com>
Committed: Wed Jan 16 13:48:57 2019 +0700

----------------------------------------------------------------------
 .../org/apache/james/rrt/lib/MappingSourceTest.java     | 12 +++++++++++-
 .../rrt/lib/AbstractRecipientRewriteTableTest.java      |  4 ++--
 2 files changed, 13 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/4cdfef08/server/data/data-api/src/test/java/org/apache/james/rrt/lib/MappingSourceTest.java
----------------------------------------------------------------------
diff --git a/server/data/data-api/src/test/java/org/apache/james/rrt/lib/MappingSourceTest.java b/server/data/data-api/src/test/java/org/apache/james/rrt/lib/MappingSourceTest.java
index 9088b42..c467bb7 100644
--- a/server/data/data-api/src/test/java/org/apache/james/rrt/lib/MappingSourceTest.java
+++ b/server/data/data-api/src/test/java/org/apache/james/rrt/lib/MappingSourceTest.java
@@ -19,18 +19,28 @@
 
 package org.apache.james.rrt.lib;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import org.apache.james.core.Domain;
 import org.apache.james.core.MailAddress;
 import org.apache.james.core.User;
 import org.junit.jupiter.api.Test;
 
-import static org.assertj.core.api.Assertions.assertThat;
+import nl.jqno.equalsverifier.EqualsVerifier;
+
 class MappingSourceTest {
     private static final String DOMAIN = "domain.tld";
     private static final  String USER = "alice";
     private static final String MAIL_ADDRESS = USER + "@" + DOMAIN;
 
     @Test
+    void shouldRespectBeanContract() {
+        EqualsVerifier.forClass(MappingSource.class)
+            .withIgnoredFields("wildcard")
+            .verify();
+    }
+
+    @Test
     void asMailAddressStringShouldSerializeWilcard() {
         MappingSource mappingSource = MappingSource.wildCard();
 

http://git-wip-us.apache.org/repos/asf/james-project/blob/4cdfef08/server/data/data-library/src/test/java/org/apache/james/rrt/lib/AbstractRecipientRewriteTableTest.java
----------------------------------------------------------------------
diff --git a/server/data/data-library/src/test/java/org/apache/james/rrt/lib/AbstractRecipientRewriteTableTest.java b/server/data/data-library/src/test/java/org/apache/james/rrt/lib/AbstractRecipientRewriteTableTest.java
index f5e26af..955fe75 100644
--- a/server/data/data-library/src/test/java/org/apache/james/rrt/lib/AbstractRecipientRewriteTableTest.java
+++ b/server/data/data-library/src/test/java/org/apache/james/rrt/lib/AbstractRecipientRewriteTableTest.java
@@ -474,7 +474,7 @@ public abstract class AbstractRecipientRewriteTableTest {
     }
 
     @Test
-    public void getSourcesForTypeShouldReturnSortedList() throws Exception {
+    public void getSourcesForTypeShouldReturnSortedStream() throws Exception {
         MappingSource source1 = MappingSource.fromUser("alice", Domain.LOCALHOST);
         MappingSource source2 = MappingSource.fromUser("bob", Domain.LOCALHOST);
         MappingSource source3 = MappingSource.fromUser("cedric", Domain.LOCALHOST);
@@ -517,7 +517,7 @@ public abstract class AbstractRecipientRewriteTableTest {
     }
 
     @Test
-    public void getMappingsForTypeShouldReturnSortedList() throws Exception {
+    public void getMappingsForTypeShouldReturnSortedStream() throws Exception {
         String address1 = "alice@domain.com";
         String address2 = "bob@domain.com";
         String address3 = "cedric@domain.com";


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org