You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by jh...@apache.org on 2017/09/28 02:55:04 UTC
[13/50] [abbrv] hadoop git commit: HADOOP-14892. MetricsSystemImpl
should use Time.monotonicNow for measuring durations. Contributed by Chetna
Chaudhari.
HADOOP-14892. MetricsSystemImpl should use Time.monotonicNow for measuring durations. Contributed by Chetna Chaudhari.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/3a10367a
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/3a10367a
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/3a10367a
Branch: refs/heads/YARN-5734
Commit: 3a10367a17b99e2c3035ec54048f94f334d93227
Parents: 02e2a9b
Author: Akira Ajisaka <aa...@apache.org>
Authored: Tue Sep 26 01:47:02 2017 +0900
Committer: Akira Ajisaka <aa...@apache.org>
Committed: Tue Sep 26 01:47:02 2017 +0900
----------------------------------------------------------------------
.../org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/3a10367a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
index 2248122..ee1672e 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
@@ -415,10 +415,10 @@ public class MetricsSystemImpl extends MetricsSystem implements MetricsSource {
private void snapshotMetrics(MetricsSourceAdapter sa,
MetricsBufferBuilder bufferBuilder) {
- long startTime = Time.now();
+ long startTime = Time.monotonicNow();
bufferBuilder.add(sa.name(), sa.getMetrics(collector, true));
collector.clear();
- snapshotStat.add(Time.now() - startTime);
+ snapshotStat.add(Time.monotonicNow() - startTime);
LOG.debug("Snapshotted source "+ sa.name());
}
@@ -431,7 +431,7 @@ public class MetricsSystemImpl extends MetricsSystem implements MetricsSource {
synchronized void publishMetrics(MetricsBuffer buffer, boolean immediate) {
int dropped = 0;
for (MetricsSinkAdapter sa : sinks.values()) {
- long startTime = Time.now();
+ long startTime = Time.monotonicNow();
boolean result;
if (immediate) {
result = sa.putMetricsImmediate(buffer);
@@ -439,7 +439,7 @@ public class MetricsSystemImpl extends MetricsSystem implements MetricsSource {
result = sa.putMetrics(buffer, logicalTime);
}
dropped += result ? 0 : 1;
- publishStat.add(Time.now() - startTime);
+ publishStat.add(Time.monotonicNow() - startTime);
}
droppedPubAll.incr(dropped);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org