You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/19 16:01:05 UTC

Review Request 39438: Expose in the API whether downgrade is supported or not

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39438/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-13458
    https://issues.apache.org/jira/browse/AMBARI-13458


Repository: ambari


Description
-------

Patch https://reviews.apache.org/r/39402/ merged for 2.1
Need API to expose whether a downgrade is supported or not, so that the UI can display the downgrade button accordingly.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 27e3377 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java ad9073a 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 5a8031b 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a94723f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bb0c724 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c884d07 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7f8b981 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 93a5dc8 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 621a524 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 72d2d25 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 1da05c2 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java f6d1acf 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 8d82967 

Diff: https://reviews.apache.org/r/39438/diff/


Testing
-------

patch does not introduce additional unit test failures


Thanks,

Dmitro Lisnichenko


Re: Review Request 39438: Expose in the API whether downgrade is supported or not

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Oct. 19, 2015, 10:04 p.m., Jonathan Hurley wrote:
> > This is the same patch, just for the 2.1 branch?

yes


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39438/#review103168
-----------------------------------------------------------


On Oct. 19, 2015, 2:01 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39438/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 2:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-13458
>     https://issues.apache.org/jira/browse/AMBARI-13458
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch https://reviews.apache.org/r/39402/ merged for 2.1
> Need API to expose whether a downgrade is supported or not, so that the UI can display the downgrade button accordingly.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 27e3377 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java ad9073a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 5a8031b 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a94723f 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bb0c724 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c884d07 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7f8b981 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 93a5dc8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 621a524 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 72d2d25 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 1da05c2 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java f6d1acf 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 8d82967 
> 
> Diff: https://reviews.apache.org/r/39438/diff/
> 
> 
> Testing
> -------
> 
> patch does not introduce additional unit test failures
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 39438: Expose in the API whether downgrade is supported or not

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39438/#review103168
-----------------------------------------------------------

Ship it!


This is the same patch, just for the 2.1 branch?

- Jonathan Hurley


On Oct. 19, 2015, 10:01 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39438/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 10:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-13458
>     https://issues.apache.org/jira/browse/AMBARI-13458
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch https://reviews.apache.org/r/39402/ merged for 2.1
> Need API to expose whether a downgrade is supported or not, so that the UI can display the downgrade button accordingly.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 27e3377 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java ad9073a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 5a8031b 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a94723f 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bb0c724 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c884d07 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7f8b981 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 93a5dc8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 621a524 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 72d2d25 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 1da05c2 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java f6d1acf 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 8d82967 
> 
> Diff: https://reviews.apache.org/r/39438/diff/
> 
> 
> Testing
> -------
> 
> patch does not introduce additional unit test failures
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>