You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 04:08:33 UTC

[GitHub] [spark] zhengruifeng opened a new pull request #26305: [SPARK-29645][ML][PYSPARK] ML add param RelativeError

zhengruifeng opened a new pull request #26305: [SPARK-29645][ML][PYSPARK] ML add param RelativeError
URL: https://github.com/apache/spark/pull/26305
 
 
   ### What changes were proposed in this pull request?
   1, add shared param `relativeError`
   2, `Imputer`/`RobusterScaler`/`QuantileDiscretizer` extend `HasRelativeError`
   
   ### Why are the changes needed?
   It makes sense to expose RelativeError to end users, since it controls both the precision and memory overhead.
   `QuantileDiscretizer` had already added this param, while other algs not yet.
   
   
   
   ### Does this PR introduce any user-facing change?
   yes, new param is added in  `Imputer`/`RobusterScaler`
   
   ### How was this patch tested?
   existing testsutes
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org