[jira] Commented: (MRESOURCES-37) Refactor

["Brett Porter (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MRESOURCES-37?page=comments#action_83284 ] 
            
Brett Porter commented on MRESOURCES-37:
----------------------------------------

unfortunately, the second patch doesn't apply, even against the latest revision. Perhaps the line endings are the problem. Can you regenerate it?

> Refactor
> --------
>
>                 Key: MRESOURCES-37
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-37
>             Project: Maven 2.x Resources Plugin
>          Issue Type: Improvement
>            Reporter: Franz Allan Valencia See
>            Priority: Minor
>         Attachments: MRESOURCES-37-maven-resources-plugin-2.patch, MRESOURCES-37-maven-resources-plugin.patch
>
>
> Good day,
> Right now, ResourcesMojo is inherited by TestResourcesMojo...not the usual setup (there's usually an abstract mojo to inherit, not a working concrete mojo).
> Furthermore, the TestResourcesMojoTest seems to be not finished as well. And it seems as though it was going to be a duplicate of ResourcesMojoTest. Thus, i refactored those too. Actually, i was about to complete the TestResourcesMojoTest when I decided to refactor everything.
> Anyway, I most just extracted some classes and methods. Other than that, the overall flow is still the same. ...And deleted an unused part of plugin-config.xml to avoid confusion when traciing the test cases.
> Cheers,
> Franz

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira