You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Robert Burke (Jira)" <ji...@apache.org> on 2020/09/16 17:58:00 UTC
[jira] [Updated] (BEAM-6577) The shim generator doesn't examine
func return types when generating necessary imports
[ https://issues.apache.org/jira/browse/BEAM-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burke updated BEAM-6577:
-------------------------------
Status: Resolved (was: Open)
> The shim generator doesn't examine func return types when generating necessary imports
> --------------------------------------------------------------------------------------
>
> Key: BEAM-6577
> URL: https://issues.apache.org/jira/browse/BEAM-6577
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Tianyang Hu
> Priority: P3
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For the following function:
> {code:java}
> func myDoFn(s string) mypkg.MyType {...}
> {code}
> it's shim generated code doesn't import "mypkg", which leads to compilation error "undefined mypkg..."
> Seems that the func parser inspects only the input params, not return params: https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/starcgenx/starcgenx.go#L293
> Should we do the same for return types?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)