You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/03/13 06:05:40 UTC

[PR] c_glib: Disable keep-alive for stable result with Ruby server [arrow-experiments]

kou opened a new pull request, #20:
URL: https://github.com/apache/arrow-experiments/pull/20

   This is for suppressing needless error message with Ruby server.
   
   See also:
   * https://github.com/apache/arrow-experiments/pull/17#issuecomment-1991629068
   * https://github.com/apache/arrow-experiments/pull/17#issuecomment-1993628546


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] c_glib: Disable keep-alive for stable result with Ruby server [arrow-experiments]

Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook merged PR #20:
URL: https://github.com/apache/arrow-experiments/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] c_glib: Disable keep-alive for stable result with Ruby server [arrow-experiments]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #20:
URL: https://github.com/apache/arrow-experiments/pull/20#discussion_r1524082712


##########
http/get_simple/c_glib/client/client.c:
##########
@@ -30,6 +30,15 @@ main(int argc, char **argv)
   SoupSession *session = soup_session_new();
   SoupMessage *message = soup_message_new(SOUP_METHOD_GET,
                                           "http://localhost:8008");
+  /* Disable keep-alive explicitly. (libsoup uses keep-alive by
+   * default.)
+   *
+   * In general, keep-alive will improve performance when we sends

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] c_glib: Disable keep-alive for stable result with Ruby server [arrow-experiments]

Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on code in PR #20:
URL: https://github.com/apache/arrow-experiments/pull/20#discussion_r1523018432


##########
http/get_simple/c_glib/client/client.c:
##########
@@ -30,6 +30,15 @@ main(int argc, char **argv)
   SoupSession *session = soup_session_new();
   SoupMessage *message = soup_message_new(SOUP_METHOD_GET,
                                           "http://localhost:8008");
+  /* Disable keep-alive explicitly. (libsoup uses keep-alive by
+   * default.)
+   *
+   * In general, keep-alive will improve performance when we sends

Review Comment:
   ```suggestion
      * In general, keep-alive will improve performance when we send
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org