[GitHub] [incubator-mxnet] szha commented on a change in pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#discussion_r688833379



##########
File path: docs/python_docs/python/tutorials/packages/np/cheat-sheet.md
##########
@@ -90,7 +90,7 @@ npx.load('my_array')
 ```{.python .input}
 # Save a list of arrays
 b = np.array([4, 6, 8])
-npx.save('my_arrays', [a, b])  # FIXME, cannot be a tuple
+npx.savez('my_arrays', *[a, b])  # FIXME, cannot be a tuple

Review comment:
       Is this comment still relevant?

##########
File path: docs/python_docs/python/scripts/md2ipynb.py
##########
@@ -26,17 +26,28 @@ def md2ipynb():
     (src_fn, input_fn, output_fn) = sys.argv
 
     # timeout for each notebook, in sec
-    timeout = 20 * 60
+    timeout = 60 * 60
     # if enable evaluation
     do_eval = int(os.environ.get('EVAL', True))
+    
+    # Skip these notebooks as some APIs will no longer be used
+    skip_list = ["pytorch.md", "mnist.md", "custom-loss.md", "fit_api_tutorial.md", \
+        "01-ndarray-intro.md", "02-ndarray-operations.md", "03-ndarray-contexts.md", \
+        "gotchas_numpy_in_mxnet.md", "csr.md", "row_sparse.md", "fine_tuning_gluon.md", \
+        "inference_on_onnx_model.md", "amp.md", "profiler.md"]

Review comment:
       Let's create an issue to track them in case some is still applicable in 2.0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org