[GitHub] [kafka] fvaleri commented on a diff in pull request #12656: MINOR: Update offset.storage.topic description

[GitBox <gi...@apache.org>]

fvaleri commented on code in PR #12656:
URL: https://github.com/apache/kafka/pull/12656#discussion_r974366092


##########
docs/connect.html:
##########
@@ -53,7 +53,7 @@ <h4><a id="connect_running" href="#connect_running">Running Kafka Connect</a></h
 
     <p>The important configuration options specific to standalone mode are:</p>
     <ul>
-        <li><code>offset.storage.file.filename</code> - File to store offset data in</li>
+        <li><code>offset.storage.file.filename</code> - File to store source task offsets</li>

Review Comment:
   Thanks.



##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneConfig.java:
##########
@@ -28,7 +28,7 @@ public class StandaloneConfig extends WorkerConfig {
      * <code>offset.storage.file.filename</code>
      */
     public static final String OFFSET_STORAGE_FILE_FILENAME_CONFIG = "offset.storage.file.filename";
-    private static final String OFFSET_STORAGE_FILE_FILENAME_DOC = "File to store offset data in";
+    private static final String OFFSET_STORAGE_FILE_FILENAME_DOC = "File to store source task offsets";

Review Comment:
   Yes, I like consistency. Thanks.



##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -108,7 +108,7 @@ public class WorkerConfig extends AbstractConfig {
 
     public static final String OFFSET_COMMIT_INTERVAL_MS_CONFIG = "offset.flush.interval.ms";
     private static final String OFFSET_COMMIT_INTERVAL_MS_DOC
-            = "Interval at which to try committing offsets for tasks.";
+            = "Interval at which to try committing offsets for source tasks.";

Review Comment:
   Right, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org