You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/06/15 08:14:51 UTC

[GitHub] [openwhisk-deploy-kube] ningyougang opened a new pull request #611: Support external kafka zookeeper

ningyougang opened a new pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611


   - [x] support external kafka/zookeeper.
   
   If want to support external kafka/zookeeper, just add below configuration to mycluster.yaml, e.g.
   ```
   zookeeper:
     external: true
     host: ${zookeeper_host}
     port: ${zookeeper_port}
   
   kafka:
     external: true
     host: ${kafka_host}
     port: ${kafka_port}
   ```
   I tested in my local, works well


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611#issuecomment-646382494


   Also, when you have time please rebase to latest master.  I merged #612 which disables a couple of test cases which have been failing almost all the time in travis.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] ningyougang closed pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] ningyougang edited a comment on pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
ningyougang edited a comment on pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611#issuecomment-647952994


   @dgrove-oss , already changed to ` connect string` style and already rebased as well.
   Let's see whether test cases passed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] ningyougang commented on a change in pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
ningyougang commented on a change in pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611#discussion_r440003895



##########
File path: helm/openwhisk/templates/_helpers.tpl
##########
@@ -66,30 +66,36 @@ app: {{ template "openwhisk.fullname" . }}
 
 {{/* client connection string for zookeeper cluster (server1:port,server2:port, ... serverN:port)*/}}
 {{- define "openwhisk.zookeeper_connect" -}}
+{{- if .Values.zookeeper.external -}}
+{{ .Values.zookeeper.host }}:{{ .Values.zookeeper.port }}
+{{- else -}}
 {{- $zkname := printf "%s-zookeeper" .Release.Name }}
 {{- $zkport := .Values.zookeeper.port }}
 {{- $kubeDomain := .Values.k8s.domain }}
 {{- range $i, $e := until (int .Values.zookeeper.replicaCount) -}}{{ if ne $i 0 }},{{ end }}{{ $zkname }}-{{ . }}.{{ $zkname }}.{{ $.Release.Namespace }}.svc.{{ $kubeDomain }}:{{ $zkport }}{{ end }}
 {{- end -}}
+{{- end -}}
 
 {{/* host name for server.0 in zookeeper cluster */}}
 {{- define "openwhisk.zookeeper_zero_host" -}}
+{{- if .Values.zookeeper.external -}}
+{{ .Values.zookeeper.host }}
+{{- else -}}
 {{- $zkname := printf "%s-zookeeper" .Release.Name }}
 {{ $zkname }}-0.{{ $zkname }}.{{ $.Release.Namespace }}.svc.{{ .Values.k8s.domain }}
 {{- end -}}
+{{- end -}}
 
 {{/* client connection string for kafka cluster (server1:port,server2:port, ... serverN:port)*/}}
 {{- define "openwhisk.kafka_connect" -}}
+{{- if .Values.kafka.external -}}
+{{ .Values.kafka.host }}:{{ .Values.kafka.port }}
+{{- else -}}
 {{- $kname := printf "%s-kafka" .Release.Name }}
 {{- $kport := .Values.kafka.port }}
 {{- $kubeDomain := .Values.k8s.domain }}
 {{- range $i, $e := until (int .Values.kafka.replicaCount) -}}{{ if ne $i 0 }},{{ end }}{{ $kname }}-{{ . }}.{{ $kname }}.{{ $.Release.Namespace }}.svc.{{ $kubeDomain }}:{{ $kport }}{{ end }}
 {{- end -}}
-
-{{/* host name for server.0 in kafka cluster */}}
-{{- define "openwhisk.kafka_zero_host" -}}
-{{- $kname := printf "%s-kafka" .Release.Name }}
-{{ $kname }}-0.{{ $kname }}.{{ $.Release.Namespace }}.svc.{{ .Values.k8s.domain }}

Review comment:
       The template `openwhisk.kafka_zero_host` is not used in other places.
   So i deleted it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] ningyougang commented on a change in pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
ningyougang commented on a change in pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611#discussion_r440003895



##########
File path: helm/openwhisk/templates/_helpers.tpl
##########
@@ -66,30 +66,36 @@ app: {{ template "openwhisk.fullname" . }}
 
 {{/* client connection string for zookeeper cluster (server1:port,server2:port, ... serverN:port)*/}}
 {{- define "openwhisk.zookeeper_connect" -}}
+{{- if .Values.zookeeper.external -}}
+{{ .Values.zookeeper.host }}:{{ .Values.zookeeper.port }}
+{{- else -}}
 {{- $zkname := printf "%s-zookeeper" .Release.Name }}
 {{- $zkport := .Values.zookeeper.port }}
 {{- $kubeDomain := .Values.k8s.domain }}
 {{- range $i, $e := until (int .Values.zookeeper.replicaCount) -}}{{ if ne $i 0 }},{{ end }}{{ $zkname }}-{{ . }}.{{ $zkname }}.{{ $.Release.Namespace }}.svc.{{ $kubeDomain }}:{{ $zkport }}{{ end }}
 {{- end -}}
+{{- end -}}
 
 {{/* host name for server.0 in zookeeper cluster */}}
 {{- define "openwhisk.zookeeper_zero_host" -}}
+{{- if .Values.zookeeper.external -}}
+{{ .Values.zookeeper.host }}
+{{- else -}}
 {{- $zkname := printf "%s-zookeeper" .Release.Name }}
 {{ $zkname }}-0.{{ $zkname }}.{{ $.Release.Namespace }}.svc.{{ .Values.k8s.domain }}
 {{- end -}}
+{{- end -}}
 
 {{/* client connection string for kafka cluster (server1:port,server2:port, ... serverN:port)*/}}
 {{- define "openwhisk.kafka_connect" -}}
+{{- if .Values.kafka.external -}}
+{{ .Values.kafka.host }}:{{ .Values.kafka.port }}
+{{- else -}}
 {{- $kname := printf "%s-kafka" .Release.Name }}
 {{- $kport := .Values.kafka.port }}
 {{- $kubeDomain := .Values.k8s.domain }}
 {{- range $i, $e := until (int .Values.kafka.replicaCount) -}}{{ if ne $i 0 }},{{ end }}{{ $kname }}-{{ . }}.{{ $kname }}.{{ $.Release.Namespace }}.svc.{{ $kubeDomain }}:{{ $kport }}{{ end }}
 {{- end -}}
-
-{{/* host name for server.0 in kafka cluster */}}
-{{- define "openwhisk.kafka_zero_host" -}}
-{{- $kname := printf "%s-kafka" .Release.Name }}
-{{ $kname }}-0.{{ $kname }}.{{ $.Release.Namespace }}.svc.{{ .Values.k8s.domain }}

Review comment:
       The template `openwhisk.kafka_zero_host` is not used in other places.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] jiangpengcheng merged pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
jiangpengcheng merged pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] ningyougang closed pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611#issuecomment-646382042


   Should we generalize to supporting an external replicated zookeeper and kafka?  Instead of having just a single external host in values.yaml, have a complete external connect string (`h1:p1,h2:p2,....hk:pk`).  When we deploy the internal zookeeper/kafka we support replication.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] ningyougang commented on pull request #611: Support external kafka zookeeper

Posted by GitBox <gi...@apache.org>.
ningyougang commented on pull request #611:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/611#issuecomment-647952994


   @dgrove-oss , already rebased
   Let's see whether test cases passed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org