[GitHub] patricker edited a comment on issue #3260: NIFI-5790 removed the last test as it's causing a race condition intermittently

[GitBox <gi...@apache.org>]

patricker edited a comment on issue #3260: NIFI-5790 removed the last test as it's causing a race condition intermittently
URL: https://github.com/apache/nifi/pull/3260#issuecomment-453241832
 
 
   @colindean We went ahead and removed the very last test. This still leaves in most of the testing of functionality, but removes the time based portion where connections invalidate over some time period.
   
   I looked at the base dbcp2 code, and even they just kind of skip testing on this part... it's hard to do good testing on timer based events unless you are willing to `sleep` a really long time. Don't sweat not being able to assist further, no features have been lost.
   
   **Correction**
   We removed the very last Assert, all of the rest of the tests in that test case are still intact. 2 lines removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services