You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "z7658329 (via GitHub)" <gi...@apache.org> on 2023/02/11 10:09:21 UTC

[GitHub] [incubator-hugegraph] z7658329 opened a new pull request, #2109: validate release support mulit os

z7658329 opened a new pull request, #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109

   test see:
   https://github.com/z7658329/hugegraph/actions/runs/4150859892


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2109: validate release support mulit os

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1109427677


##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -25,6 +25,7 @@ URL_PREFIX="https://dist.apache.org/repos/dist/dev/incubator/hugegraph/"
 # release version (input by committer)
 RELEASE_VERSION=$1
 JAVA_VERSION=$2
+USER=$3

Review Comment:
   > > also move this file to hugegraph-doc repo?
   > 
   > It can be discussed that the server keep validate shell script while hugegraph-doc keep ci actions ? @javeme @imbajin
   
   Both fine, and wait until the **first release** is completed. After confirming the stability, we can handle current PR(so as the doc's),  could leave it alone for now
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] z7658329 commented on a diff in pull request #2109: validate release support mulit os

Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1109391216


##########
.github/workflows/validate-release.yml:
##########
@@ -1,21 +1,33 @@
-name: Validate Apache Release
-
+name: "Validate Apache Release"
+#latest please refer: https://github.com/apache/incubator-hugegraph-doc/blob/master/.github/workflows/validate-release.yml

Review Comment:
   > can we use the remote script and delete this file?
   
   ok, we can see the apache release validate ci in hugegraph-doc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2109: move validate release to hugegraph-doc

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1114349630


##########
hugegraph-dist/pom.xml:
##########
@@ -181,6 +181,7 @@
                         <configuration>
                             <tasks>
                                 <echo file="${project.basedir}/dist.sh">
+                                    wget --version 1>/dev/null || exit

Review Comment:
   **TODO:** use curl to replace it (and refer a better way to handle it -- like maven property)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #2109: validate release support mulit os

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#issuecomment-1426686378

   # [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2109](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7c15e6) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/c8e0f0c3e12a47694501703e2cabfc9bd97d671c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8e0f0c) will **decrease** coverage by `20.91%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #2109       +/-   ##
   =============================================
   - Coverage     69.38%   48.47%   -20.91%     
   + Complexity      977      652      -325     
   =============================================
     Files           479      479               
     Lines         39655    39598       -57     
     Branches       5578     5555       -23     
   =============================================
   - Hits          27513    19197     -8316     
   - Misses         9489    18333     +8844     
   + Partials       2653     2068      -585     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/hugegraph/util/FixedWatchWindowRateLimiter.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC91dGlsL0ZpeGVkV2F0Y2hXaW5kb3dSYXRlTGltaXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...he/hugegraph/backend/store/mysql/MysqlMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9teXNxbC9NeXNxbE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/backend/store/raft/RaftStoreClosure.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3JhZnQvUmFmdFN0b3JlQ2xvc3VyZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/job/schema/OlapPropertyKeyCreateJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9qb2Ivc2NoZW1hL09sYXBQcm9wZXJ0eUtleUNyZWF0ZUpvYi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/job/schema/OlapPropertyKeyRemoveJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9qb2Ivc2NoZW1hL09sYXBQcm9wZXJ0eUtleVJlbW92ZUpvYi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ugegraph/backend/store/memory/InMemoryMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL21lbW9yeS9Jbk1lbW9yeU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...egraph/backend/store/hbase/HbaseStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWhiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9oYmFzZS9IYmFzZVN0b3JlUHJvdmlkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...egraph/backend/store/scylladb/ScyllaDBMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9zY3lsbGFkYi9TY3lsbGFEQk1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...graph/backend/store/scylladb/ScyllaDBFeatures.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9zY3lsbGFkYi9TY3lsbGFEQkZlYXR1cmVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ackend/store/cassandra/CassandraStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvY2Fzc2FuZHJhL0Nhc3NhbmRyYVN0b3JlUHJvdmlkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [197 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/2109?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2109: validate release support mulit os

Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1104486888


##########
.github/workflows/validate-release.yml:
##########
@@ -1,21 +1,33 @@
-name: Validate Apache Release
-
+name: "Validate Apache Release"
+#latest please refer: https://github.com/apache/incubator-hugegraph-doc/blob/master/.github/workflows/validate-release.yml

Review Comment:
   can we use the remote script and delete this file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2109: validate release support mulit os

Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1105897713


##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -87,91 +110,102 @@ for i in *src.tar.gz; do
   cd .. || exit
 done
 
-#### step4.3: run the compiled packages in server
+#### step5: run the compiled packages in server
 ls -lh
 cd ./*hugegraph-incubating*src/*hugegraph*"${RELEASE_VERSION}" || exit
 bin/init-store.sh && sleep 1
 bin/start-hugegraph.sh && ls ../../
 cd ../../ || exit
 
-#### step4.4: run the compiled packages in toolchain (include loader/tool/hubble)
+#### step6: run the compiled packages in toolchain (include loader/tool/hubble)
 cd ./*toolchain*src || exit
 ls -lh
 cd ./*toolchain*"${RELEASE_VERSION}" || exit
 ls -lh
 
-##### 4.4.1 test loader
+##### step6.1: test loader
 cd ./*loader*"${RELEASE_VERSION}" || exit
 bin/hugegraph-loader.sh -f ./example/file/struct.json -s ./example/file/schema.groovy \
   -g hugegraph || exit
 cd .. || exit
 
-##### 4.4.2 test tool
+##### step6.2: test tool
 cd ./*tool*"${RELEASE_VERSION}" || exit
 bin/hugegraph gremlin-execute --script 'g.V().count()' || exit
 bin/hugegraph task-list || exit
 bin/hugegraph backup -t all --directory ./backup-test || exit
 cd .. || exit
 
-##### 4.4.3 test hubble
+##### step6.3: test hubble
 cd ./*hubble*"${RELEASE_VERSION}" || exit
 # TODO: add hubble doc & test it
 cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
 cd ../../../ || exit
 
-# step5: validate the binary packages
-#### step5.0: check the directory name include "incubating"
-#### step5.1: check the directory include "NOTICE" and "LICENSE" file
+# step7: validate the binary packages
 rm -rf ./*src* && ls -lh
 for i in *.tar.gz; do
   echo "$i"
+  #### step7.1: check the directory name include "incubating"
   if [[ ! "$i" =~ "incubating" ]]; then
-    echo "The package name should include incubating" && exit 1
+    echo "The package name:$i should include incubating" && exit 1

Review Comment:
   "name:$i" -- prefer `name $i`



##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -25,6 +25,7 @@ URL_PREFIX="https://dist.apache.org/repos/dist/dev/incubator/hugegraph/"
 # release version (input by committer)
 RELEASE_VERSION=$1
 JAVA_VERSION=$2
+USER=$3

Review Comment:
   also move this file to hugegraph-doc repo?



##########
.github/workflows/validate-release.yml:
##########
@@ -1,21 +1,33 @@
-name: Validate Apache Release
-
+name: "Validate Apache Release"
+#latest please refer: https://github.com/apache/incubator-hugegraph-doc/blob/master/.github/workflows/validate-release.yml

Review Comment:
   can we just delete this file?



##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -87,91 +110,102 @@ for i in *src.tar.gz; do
   cd .. || exit
 done
 
-#### step4.3: run the compiled packages in server
+#### step5: run the compiled packages in server
 ls -lh
 cd ./*hugegraph-incubating*src/*hugegraph*"${RELEASE_VERSION}" || exit
 bin/init-store.sh && sleep 1
 bin/start-hugegraph.sh && ls ../../
 cd ../../ || exit
 
-#### step4.4: run the compiled packages in toolchain (include loader/tool/hubble)
+#### step6: run the compiled packages in toolchain (include loader/tool/hubble)
 cd ./*toolchain*src || exit
 ls -lh
 cd ./*toolchain*"${RELEASE_VERSION}" || exit
 ls -lh
 
-##### 4.4.1 test loader
+##### step6.1: test loader
 cd ./*loader*"${RELEASE_VERSION}" || exit
 bin/hugegraph-loader.sh -f ./example/file/struct.json -s ./example/file/schema.groovy \
   -g hugegraph || exit
 cd .. || exit
 
-##### 4.4.2 test tool
+##### step6.2: test tool
 cd ./*tool*"${RELEASE_VERSION}" || exit
 bin/hugegraph gremlin-execute --script 'g.V().count()' || exit
 bin/hugegraph task-list || exit
 bin/hugegraph backup -t all --directory ./backup-test || exit
 cd .. || exit
 
-##### 4.4.3 test hubble
+##### step6.3: test hubble
 cd ./*hubble*"${RELEASE_VERSION}" || exit
 # TODO: add hubble doc & test it
 cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
 cd ../../../ || exit
 
-# step5: validate the binary packages
-#### step5.0: check the directory name include "incubating"
-#### step5.1: check the directory include "NOTICE" and "LICENSE" file
+# step7: validate the binary packages
 rm -rf ./*src* && ls -lh
 for i in *.tar.gz; do
   echo "$i"
+  #### step7.1: check the directory name include "incubating"
   if [[ ! "$i" =~ "incubating" ]]; then
-    echo "The package name should include incubating" && exit 1
+    echo "The package name:$i should include incubating" && exit 1

Review Comment:
   "name:$i" -- prefer` name $i`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] z7658329 commented on a diff in pull request #2109: validate release support mulit os

Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1109396733


##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -87,91 +110,102 @@ for i in *src.tar.gz; do
   cd .. || exit
 done
 
-#### step4.3: run the compiled packages in server
+#### step5: run the compiled packages in server
 ls -lh
 cd ./*hugegraph-incubating*src/*hugegraph*"${RELEASE_VERSION}" || exit
 bin/init-store.sh && sleep 1
 bin/start-hugegraph.sh && ls ../../
 cd ../../ || exit
 
-#### step4.4: run the compiled packages in toolchain (include loader/tool/hubble)
+#### step6: run the compiled packages in toolchain (include loader/tool/hubble)
 cd ./*toolchain*src || exit
 ls -lh
 cd ./*toolchain*"${RELEASE_VERSION}" || exit
 ls -lh
 
-##### 4.4.1 test loader
+##### step6.1: test loader
 cd ./*loader*"${RELEASE_VERSION}" || exit
 bin/hugegraph-loader.sh -f ./example/file/struct.json -s ./example/file/schema.groovy \
   -g hugegraph || exit
 cd .. || exit
 
-##### 4.4.2 test tool
+##### step6.2: test tool
 cd ./*tool*"${RELEASE_VERSION}" || exit
 bin/hugegraph gremlin-execute --script 'g.V().count()' || exit
 bin/hugegraph task-list || exit
 bin/hugegraph backup -t all --directory ./backup-test || exit
 cd .. || exit
 
-##### 4.4.3 test hubble
+##### step6.3: test hubble
 cd ./*hubble*"${RELEASE_VERSION}" || exit
 # TODO: add hubble doc & test it
 cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
 cd ../../../ || exit
 
-# step5: validate the binary packages
-#### step5.0: check the directory name include "incubating"
-#### step5.1: check the directory include "NOTICE" and "LICENSE" file
+# step7: validate the binary packages
 rm -rf ./*src* && ls -lh
 for i in *.tar.gz; do
   echo "$i"
+  #### step7.1: check the directory name include "incubating"
   if [[ ! "$i" =~ "incubating" ]]; then
-    echo "The package name should include incubating" && exit 1
+    echo "The package name:$i should include incubating" && exit 1

Review Comment:
   > "name:$i" -- prefer `name $i`
   
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2109: validate release support mulit os

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1109427677


##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -25,6 +25,7 @@ URL_PREFIX="https://dist.apache.org/repos/dist/dev/incubator/hugegraph/"
 # release version (input by committer)
 RELEASE_VERSION=$1
 JAVA_VERSION=$2
+USER=$3

Review Comment:
   > > also move this file to hugegraph-doc repo?
   > 
   > It can be discussed that the server keep validate shell script while hugegraph-doc keep ci actions ? @javeme @imbajin
   
   Both fine, and wait until the **first release** is completed. After confirming the stability, we can merge current PR, 
   could leave it alone for now
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] z7658329 commented on a diff in pull request #2109: validate release support mulit os

Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1109392988


##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -25,6 +25,7 @@ URL_PREFIX="https://dist.apache.org/repos/dist/dev/incubator/hugegraph/"
 # release version (input by committer)
 RELEASE_VERSION=$1
 JAVA_VERSION=$2
+USER=$3

Review Comment:
   > also move this file to hugegraph-doc repo?
   
   It can be discussed that the server keep validate shell script while hugegraph-doc keep ci actions ?
   @javeme @imbajin 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] github-actions[bot] commented on pull request #2109: move validate release to hugegraph-doc

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#issuecomment-1483403940

   Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org

[GitHub] [incubator-hugegraph] imbajin commented on pull request #2109: move validate release to hugegraph-doc

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109#issuecomment-1484728425

   @z7658329 Maybe we shall merge the PR in doc first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org

[GitHub] [incubator-hugegraph] imbajin merged pull request #2109: move validate release to hugegraph-doc

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2109:
URL: https://github.com/apache/incubator-hugegraph/pull/2109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org