You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "vad0 (via GitHub)" <gi...@apache.org> on 2023/07/25 14:15:16 UTC
[GitHub] [commons-collections] vad0 opened a new pull request, #407: Make AbstractPatriciaTrie public
vad0 opened a new pull request, #407:
URL: https://github.com/apache/commons-collections/pull/407
I extend this class [here](https://github.com/vad0/gfjson/blob/master/src/main/java/org/apache/commons/collections4/trie/AsciiTrie.java) to make an implementation which works with a 'AsciiSequenceView' instead of 'String'. I forces me to create a package org.apache.commons.collections4.trie in my project. This hack works, but it prevents me from migrating to the java modules system, which prohibits using the same package names in the different modules. So I think the best solution here wil be to make AbstractPatriciaTrie public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] codecov-commenter commented on pull request #407: Make AbstractPatriciaTrie public
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #407:
URL: https://github.com/apache/commons-collections/pull/407#issuecomment-1654347054
## [Codecov](https://app.codecov.io/gh/apache/commons-collections/pull/407?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#407](https://app.codecov.io/gh/apache/commons-collections/pull/407?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b85e9da) into [master](https://app.codecov.io/gh/apache/commons-collections/commit/99473dfa205a7c476a22190ee01f0b211091987b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (99473df) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #407 +/- ##
=========================================
Coverage 81.20% 81.20%
Complexity 4625 4625
=========================================
Files 290 290
Lines 13483 13483
Branches 1993 1993
=========================================
Hits 10949 10949
Misses 1933 1933
Partials 601 601
```
| [Files Changed](https://app.codecov.io/gh/apache/commons-collections/pull/407?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ommons/collections4/trie/AbstractPatriciaTrie.java](https://app.codecov.io/gh/apache/commons-collections/pull/407?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3RyaWUvQWJzdHJhY3RQYXRyaWNpYVRyaWUuamF2YQ==) | `53.45% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] aherbert commented on pull request #407: Make AbstractPatriciaTrie public
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on PR #407:
URL: https://github.com/apache/commons-collections/pull/407#issuecomment-1651958544
The use case merits it being made public. Note that if we make it public then it needs some more javadoc as it will now appear in the javadoc API. The types <K, V> are not documented, e.g. are there limitations? One of the constructors has no javadoc, the other has no documentation of the parameters. IIUC the minimal effort would be to copy what is in the superclass `AbstractBitwiseTrie` for the type parameters and the constructors. I did not check the rest of the rendered javadoc but this should be done for completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] vad0 commented on pull request #407: Make AbstractPatriciaTrie public
Posted by "vad0 (via GitHub)" <gi...@apache.org>.
vad0 commented on PR #407:
URL: https://github.com/apache/commons-collections/pull/407#issuecomment-1652481900
Copied some javadocs from the parent class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory merged pull request #407: Make AbstractPatriciaTrie public
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #407:
URL: https://github.com/apache/commons-collections/pull/407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] Claudenw commented on pull request #407: Make AbstractPatriciaTrie public
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #407:
URL: https://github.com/apache/commons-collections/pull/407#issuecomment-1651194641
I encountered a similar problem with AbstractPatriciaTrie but ended up not using the Trie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on pull request #407: Make AbstractPatriciaTrie public
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #407:
URL: https://github.com/apache/commons-collections/pull/407#issuecomment-1651336947
Seems reasonable to make public unless I am missing something. @aherbert ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org