You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2016/12/14 08:46:48 UTC
Review Request 54733: Alerts: Create new Alerts Notification type for
SNMP to handle Ambari MIB
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54733/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-14958
https://issues.apache.org/jira/browse/AMBARI-14958
Repository: ambari
Description
-------
1) Rename current notification type "SNMP" to "Custom SNMP"
2) Create a new notification type "SNMP" that prompts for version, community, hosts, ports
3) When this is chosen, Ambari under-the-hood generates the SNMP traps based on the MIB.
4) The MIB file should be shipped with Ambari.
Diffs
-----
ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 10a7918
ambari-web/app/templates/main/alerts/create_alert_notification.hbs 342b247
ambari-web/app/views/main/alerts/manage_alert_notifications_view.js abb1694
Diff: https://reviews.apache.org/r/54733/diff/
Testing
-------
Verified Manually. Ambari-web unit tests pass.
19881 tests complete (23 seconds)
153 tests pending
Thanks,
Vivek Ratnavel Subramanian
Re: Review Request 54733: Alerts: Create new Alerts Notification type
for SNMP to handle Ambari MIB
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54733/#review159203
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Dec. 14, 2016, 8:46 a.m., Vivek Ratnavel Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54733/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 8:46 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-14958
> https://issues.apache.org/jira/browse/AMBARI-14958
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Rename current notification type "SNMP" to "Custom SNMP"
> 2) Create a new notification type "SNMP" that prompts for version, community, hosts, ports
> 3) When this is chosen, Ambari under-the-hood generates the SNMP traps based on the MIB.
> 4) The MIB file should be shipped with Ambari.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 10a7918
> ambari-web/app/templates/main/alerts/create_alert_notification.hbs 342b247
> ambari-web/app/views/main/alerts/manage_alert_notifications_view.js abb1694
>
> Diff: https://reviews.apache.org/r/54733/diff/
>
>
> Testing
> -------
>
> Verified Manually. Ambari-web unit tests pass.
> 19881 tests complete (23 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>