[jira] [Commented] (SPARK-27216) Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue

["Imran Rashid (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807181#comment-16807181 ] 

Imran Rashid commented on SPARK-27216:
--------------------------------------

Any chance you know what the issue in roaring bitmap is?  Just wondering as it is a pretty large version bump.

BTW, 0.7.45 also seems to have some big performance improvements (https://github.com/RoaringBitmap/RoaringBitmap/pull/320) for deserialization, it might be worth considering changing spark to take advantage of that (definitely a separate issue, might not even matter for the way spark uses roaring bitmap anyway ...)

> Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue
> -----------------------------------------------------------------
>
>                 Key: SPARK-27216
>                 URL: https://issues.apache.org/jira/browse/SPARK-27216
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.3.3, 2.4.0, 3.0.0
>            Reporter: Lantao Jin
>            Priority: Major
>
> HighlyCompressedMapStatus uses RoaringBitmap to record the empty blocks. But RoaringBitmap-0.5.11 couldn't be ser/deser with unsafe KryoSerializer.
> We can use below UT to reproduce:
> {code}
>   test("kryo serialization with RoaringBitmap") {
>     val bitmap = new RoaringBitmap
>     bitmap.add(1787)
>     val safeSer = new KryoSerializer(conf).newInstance()
>     val bitmap2 : RoaringBitmap = safeSer.deserialize(safeSer.serialize(bitmap))
>     assert(bitmap2.equals(bitmap))
>     conf.set("spark.kryo.unsafe", "true")
>     val unsafeSer = new KryoSerializer(conf).newInstance()
>     val bitmap3 : RoaringBitmap = unsafeSer.deserialize(unsafeSer.serialize(bitmap))
>     assert(bitmap3.equals(bitmap)) // this will fail
>   }
> {code}
> Upgrade to latest version 0.7.45 to fix it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org