[GitHub] [spark] ramon-garcia commented on a diff in pull request #41717: Withdrawn

["ramon-garcia (via GitHub)" <gi...@apache.org>]

ramon-garcia commented on code in PR #41717:
URL: https://github.com/apache/spark/pull/41717#discussion_r1245781331


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -391,6 +390,22 @@ private[parquet] class ParquetRowConverter(
             updater.setLong(timestampRebaseFunc(value))
           }
         }
+      case t: DayTimeIntervalType =>

Review Comment:
   Pushed a change that addresses your request.



##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -391,6 +390,22 @@ private[parquet] class ParquetRowConverter(
             updater.setLong(timestampRebaseFunc(value))
           }
         }
+      case t: DayTimeIntervalType =>

Review Comment:
   Thank you for your review.
   
   I understand that this issue can be fixed by restringing the DayTimeIntervalType to cases where the interval of fields is from hour to second. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org