You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by jeffnelson <gi...@git.apache.org> on 2018/04/19 20:46:12 UTC
[GitHub] commons-lang pull request #325: methods for getting first non empty or non b...
GitHub user jeffnelson opened a pull request:
https://github.com/apache/commons-lang/pull/325
methods for getting first non empty or non blank value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeffnelson/commons-lang first-non-empty-blank-string-utils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #325
----
commit 8683ebddc4693052620291603ccd8e3ae2e8efee
Author: Jeff Nelson <je...@...>
Date: 2018-04-19T20:00:19Z
methods for getting first non empty or non blank value
commit 266899409468083b53ea4b8a613570b67f80d688
Author: Jeff Nelson <je...@...>
Date: 2018-04-19T20:40:40Z
fix typo from copy paste
----
---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/325
[](https://coveralls.io/builds/16623905)
Coverage decreased (-0.01%) to 95.131% when pulling **40ed18e6065811af60125257fa5c8d3b7208aff8 on jeffnelson:first-non-empty-blank-string-utils** into **8e3ec1722bc5c70ea932b13ec1b564950c623e77 on apache:master**.
---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Posted by jeffnelson <gi...@git.apache.org>.
Github user jeffnelson commented on the issue:
https://github.com/apache/commons-lang/pull/325
@garydgregory - if you want me to refactor as such, I can. But I modeled the implementations of these 2 new methods after the existing `ObjectUtils.firstNonNull(Object T ... values)` https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/ObjectUtils.java#L125-L134
What I've submitted so far seemed like an obvious implementation choice since it is consistent with other similar existing code.
---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-lang/pull/325
Thank you for your PR. It feels to me like this new API should be built on top of a more generate "getting Nth non empty or non blank value"
---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-lang/pull/325
Your proposal is fine, my suggestion currently falls in the YAGNI category.
---
[GitHub] commons-lang pull request #325: LANG-1392 methods for getting first non empt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/325
---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/325
Thanks! 👍
---