You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/06/16 23:38:32 UTC
Review Request 35535: Use Shiro identity if available in audit logs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352
Repository: aurora
Description
-------
Use Shiro identity if available in audit logs.
Diffs
-----
config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9
src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION
src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35535/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 35535: Use Shiro identity if available in audit
logs.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88139
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Shiro identity if available in audit logs.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION
> src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35535/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35535: Use Shiro identity if available in audit
logs.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 16, 2015, 9:54 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java, line 34
> > <https://reviews.apache.org/r/35535/diff/1/?file=986082#file986082line34>
> >
> > Should this move to UnsecureSessionContext?
+1
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88136
-----------------------------------------------------------
On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Shiro identity if available in audit logs.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION
> src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35535/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35535: Use Shiro identity if available in audit
logs.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88136
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java (line 34)
<https://reviews.apache.org/r/35535/#comment140545>
Should this move to UnsecureSessionContext?
- Joshua Cohen
On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Shiro identity if available in audit logs.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION
> src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35535/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35535: Use Shiro identity if available in audit
logs.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
-----------------------------------------------------------
(Updated June 16, 2015, 3:06 p.m.)
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Changes
-------
Review feedback.
Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352
Repository: aurora
Description
-------
Use Shiro identity if available in audit logs.
Diffs (updated)
-----
config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9
src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION
src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35535/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 35535: Use Shiro identity if available in audit
logs.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
-----------------------------------------------------------
(Updated June 16, 2015, 2:54 p.m.)
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Changes
-------
Use map instead of ofNullable within flatMap.
Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352
Repository: aurora
Description
-------
Use Shiro identity if available in audit logs.
Diffs (updated)
-----
config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9
src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION
src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35535/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney