You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Scott Wegner (JIRA)" <ji...@apache.org> on 2016/04/09 01:24:25 UTC

[jira] [Created] (BEAM-185) XmlSink output file pattern missing "." in extension

Scott Wegner created BEAM-185:
---------------------------------

             Summary: XmlSink output file pattern missing "." in extension
                 Key: BEAM-185
                 URL: https://issues.apache.org/jira/browse/BEAM-185
             Project: Beam
          Issue Type: Bug
            Reporter: Scott Wegner
            Priority: Minor


The XmlSink takes as input a filename prefix and adds the shard name and extension automatically. However, it is missing the "." when adding the extension.

For an XmlSink configured as:

{{XmlSink.write().toFilenamePrefix("foobar");}}

the fileNamePattern is {{foobar-SSSSS-of-NNNNNxml}}. Instead, it should be {{foobar-SSSSS-of-NNNNN.xml}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Created] (BEAM-185) XmlSink output file pattern missing "." in extension

Posted by Lukasz Cwik <lc...@google.com>.
There is some automatic "." adding logic inside DataflowPipelineRunner,
maybe this could be extended to be generic for FileBasedSource

On Fri, Apr 8, 2016 at 4:24 PM, Scott Wegner (JIRA) <ji...@apache.org> wrote:

> Scott Wegner created BEAM-185:
> ---------------------------------
>
>              Summary: XmlSink output file pattern missing "." in extension
>                  Key: BEAM-185
>                  URL: https://issues.apache.org/jira/browse/BEAM-185
>              Project: Beam
>           Issue Type: Bug
>             Reporter: Scott Wegner
>             Priority: Minor
>
>
> The XmlSink takes as input a filename prefix and adds the shard name and
> extension automatically. However, it is missing the "." when adding the
> extension.
>
> For an XmlSink configured as:
>
> {{XmlSink.write().toFilenamePrefix("foobar");}}
>
> the fileNamePattern is {{foobar-SSSSS-of-NNNNNxml}}. Instead, it should be
> {{foobar-SSSSS-of-NNNNN.xml}}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Re: [jira] [Created] (BEAM-185) XmlSink output file pattern missing "." in extension

Posted by Lukasz Cwik <lc...@google.com.INVALID>.
There is some automatic "." adding logic inside DataflowPipelineRunner,
maybe this could be extended to be generic for FileBasedSource

On Fri, Apr 8, 2016 at 4:24 PM, Scott Wegner (JIRA) <ji...@apache.org> wrote:

> Scott Wegner created BEAM-185:
> ---------------------------------
>
>              Summary: XmlSink output file pattern missing "." in extension
>                  Key: BEAM-185
>                  URL: https://issues.apache.org/jira/browse/BEAM-185
>              Project: Beam
>           Issue Type: Bug
>             Reporter: Scott Wegner
>             Priority: Minor
>
>
> The XmlSink takes as input a filename prefix and adds the shard name and
> extension automatically. However, it is missing the "." when adding the
> extension.
>
> For an XmlSink configured as:
>
> {{XmlSink.write().toFilenamePrefix("foobar");}}
>
> the fileNamePattern is {{foobar-SSSSS-of-NNNNNxml}}. Instead, it should be
> {{foobar-SSSSS-of-NNNNN.xml}}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>