[GitHub] [spark] cloud-fan commented on a diff in pull request #37869: [SPARK-40370][SQL] Migrate type check fails to error classes in CAST

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37869:
URL: https://github.com/apache/spark/pull/37869#discussion_r993505156


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -95,6 +95,23 @@
         "message" : [
           "the binary operator requires the input type <inputType>, not <actualDataType>."
         ]
+      },
+      "CAST_WITHOUT_SUGGESTION" : {
+        "message" : [
+          "cannot cast <srcType> to <targetType>."
+        ]
+      },
+      "CAST_WITH_CONF_SUGGESTION" : {
+        "message" : [
+          "cannot cast <srcType> to <targetType> with ANSI mode on.",
+          "If you have to cast <srcType> to <targetType>, you can set <config> as <configVal>."
+        ]
+      },
+      "CAST_WITH_FUN_SUGGESTION" : {

Review Comment:
   nit: `FUN` is really confusing here. I think `FUNC` is more commonly used as a short name of FUNCTION



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org