You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/10 16:25:06 UTC
[GitHub] [singa] dcslin opened a new pull request #794: Broadcast for Mult
dcslin opened a new pull request #794:
URL: https://github.com/apache/singa/pull/794
Added broadcasted() flag for tensor
Added broadcast to mult
Refactored gpu traverse unary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690895337
# [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=h1) Report
> Merging [#794](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `4.96%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #794 +/- ##
==========================================
- Coverage 70.05% 65.09% -4.97%
==========================================
Files 100 86 -14
Lines 11556 4804 -6752
==========================================
- Hits 8096 3127 -4969
+ Misses 3460 1677 -1783
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <71.42%> (+<0.01%)` | :arrow_up: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <100.00%> (+0.34%)` | :arrow_up: |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | | |
| [utils.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | | |
| [device.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [autograd.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| [opt.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-b3B0LnB5) | | |
| ... and [8 more](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=footer). Last update [2cdb881...e97acb2](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690895337
# [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=h1) Report
> Merging [#794](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #794 +/- ##
==========================================
- Coverage 70.05% 70.05% -0.01%
==========================================
Files 100 100
Lines 11556 11573 +17
==========================================
+ Hits 8096 8107 +11
- Misses 3460 3466 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <71.42%> (+<0.01%)` | :arrow_up: |
| #singa-python | `73.57% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <100.00%> (+0.34%)` | :arrow_up: |
| [device.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | `41.86% <0.00%> (-1.33%)` | :arrow_down: |
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.79% <0.00%> (+0.63%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=footer). Last update [2cdb881...e97acb2](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690824891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690902771
@joddiy , this should be working now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690567774
Thanks, shicong, let me check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690895337
# [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=h1) Report
> Merging [#794](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #794 +/- ##
==========================================
- Coverage 70.05% 70.05% -0.01%
==========================================
Files 100 100
Lines 11556 11573 +17
==========================================
+ Hits 8096 8107 +11
- Misses 3460 3466 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <71.42%> (+<0.01%)` | :arrow_up: |
| #singa-python | `73.57% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <100.00%> (+0.34%)` | :arrow_up: |
| [device.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | `41.86% <0.00%> (-1.33%)` | :arrow_down: |
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.79% <0.00%> (+0.63%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=footer). Last update [2cdb881...e97acb2](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690447073
Hi @joddiy , could you please help to test the testcase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690895337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles merged pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #794:
URL: https://github.com/apache/singa/pull/794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690824891
> Hi, shicong, thanks for your code, it works fine for MatMul, however, it seems the `sub` has some problem now. please use the following test case to check:
>
> ```
> def high_dim_helper(self, dev):
> configs = [
> # [(1, 12, 7, 64), (1, 12, 64, 7)],
> # [(1, 7, 768), (768, 768)],
> # generate test
> [(1), (1, 1, 1, 7)],
> ]
> ops = [
> # [np.add, autograd.add],
> [np.subtract, autograd.sub],
> # [np.matmul, autograd.matmul],
> # [np.divide, autograd.div],
> ]
> for config in configs:
> for op in ops:
> X = np.random.random(config[0]).astype(np.float32)
> x = tensor.from_numpy(X)
> x.to_device(dev)
>
> W = np.random.random(config[1]).astype(np.float32)
> w = tensor.from_numpy(W)
> w.to_device(dev)
>
> y_t = op[0](X, W)
> y = op[1](x, w)
> np.testing.assert_array_almost_equal(tensor.to_numpy(y), y_t, 3)
>
> def test_high_dim_cpu(self):
> self.high_dim_helper(cpu_dev)
>
> @unittest.skipIf(not singa_wrap.USE_CUDA, 'CUDA is not enabled')
> def test_high_dim_gpu(self):
> self.high_dim_helper(gpu_dev)
> ```
Checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690895337
# [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=h1) Report
> Merging [#794](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `4.96%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #794 +/- ##
==========================================
- Coverage 70.05% 65.09% -4.97%
==========================================
Files 100 86 -14
Lines 11556 4804 -6752
==========================================
- Hits 8096 3127 -4969
+ Misses 3460 1677 -1783
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <71.42%> (+<0.01%)` | :arrow_up: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <100.00%> (+0.34%)` | :arrow_up: |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | | |
| [utils.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | | |
| [device.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [autograd.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| [opt.py](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree#diff-b3B0LnB5) | | |
| ... and [8 more](https://codecov.io/gh/apache/singa/pull/794/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=footer). Last update [2cdb881...e97acb2](https://codecov.io/gh/apache/singa/pull/794?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690902771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690895337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-691674914
> @joddiy , this should be working now
Thanks, shicong, it works fine now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy commented on pull request #794: Broadcast for Mult
Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #794:
URL: https://github.com/apache/singa/pull/794#issuecomment-690602081
Hi, shicong, thanks for your code, it works fine for MatMul, however, it seems the `sub` has some problem now. please use the following test case to check:
```
def high_dim_helper(self, dev):
configs = [
# [(1, 12, 7, 64), (1, 12, 64, 7)],
# [(1, 7, 768), (768, 768)],
# generate test
[(1), (1, 1, 1, 7)],
]
ops = [
# [np.add, autograd.add],
[np.subtract, autograd.sub],
# [np.matmul, autograd.matmul],
# [np.divide, autograd.div],
]
for config in configs:
for op in ops:
X = np.random.random(config[0]).astype(np.float32)
x = tensor.from_numpy(X)
x.to_device(dev)
W = np.random.random(config[1]).astype(np.float32)
w = tensor.from_numpy(W)
w.to_device(dev)
y_t = op[0](X, W)
y = op[1](x, w)
np.testing.assert_array_almost_equal(tensor.to_numpy(y), y_t, 3)
def test_high_dim_cpu(self):
self.high_dim_helper(cpu_dev)
@unittest.skipIf(not singa_wrap.USE_CUDA, 'CUDA is not enabled')
def test_high_dim_gpu(self):
self.high_dim_helper(gpu_dev)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org