You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/12/03 16:07:35 UTC

[GitHub] spark pull request #22468: [SPARK-25374][SQL] SafeProjection supports fallba...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22468#discussion_r238330712
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
    @@ -157,4 +157,22 @@ object InternalRow {
           getValueNullSafe
         }
       }
    +
    +  /**
    +   * Returns a writer for an `InternalRow` with given data type.
    +   */
    +  def getWriter(ordinal: Int, dt: DataType): (InternalRow, Any) => Unit = dt match {
    --- End diff --
    
    We can rebase now


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org