You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@sungard.com> on 2013/02/14 15:02:21 UTC
Re: git commit: refs/heads/4.0 - CLOUDSTACK-1265:
/etc/init.d/dnsmasq puts pid in /var/run/dnsmasq/dnsmasq.pid logrotate
checks /var/run/dnsmasq.pid instead and may not send SIGUSR2 to dnsmasq to
start writing to the new log file instead
Should this go into 4.1 as well?
On Wed, Feb 13, 2013 at 10:39:07PM +0000, chiradeep@apache.org wrote:
> Updated Branches:
> refs/heads/4.0 0be3e0bd6 -> 2dff2a85f
>
>
> CLOUDSTACK-1265: /etc/init.d/dnsmasq puts pid in /var/run/dnsmasq/dnsmasq.pid
> logrotate checks /var/run/dnsmasq.pid instead and may not send SIGUSR2 to dnsmasq to start writing to the new log file instead
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/2dff2a85
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/2dff2a85
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/2dff2a85
>
> Branch: refs/heads/4.0
> Commit: 2dff2a85f3fee4bde609b93e0a87cf1d003896cd
> Parents: 0be3e0b
> Author: Chiradeep Vittal <ch...@apache.org>
> Authored: Wed Feb 13 14:33:41 2013 -0800
> Committer: Chiradeep Vittal <ch...@apache.org>
> Committed: Wed Feb 13 14:39:02 2013 -0800
>
> ----------------------------------------------------------------------
> .../systemvm/debian/config/etc/logrotate.d/dnsmasq | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/2dff2a85/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
> ----------------------------------------------------------------------
> diff --git a/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq b/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
> index f448420..838415d3 100644
> --- a/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
> +++ b/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
> @@ -6,7 +6,7 @@
> delaycompress
> sharedscripts
> postrotate
> - [ ! -f /var/run/dnsmasq.pid ] || kill -USR2 `cat /var/run/dnsmasq.pid`
> + [ ! -f /var/run/dnsmasq/dnsmasq.pid ] || kill -USR2 `cat /var/run/dnsmasq/dnsmasq.pid`
> endscript
> create 0640 nobody root
> }
>
>
Re: git commit: refs/heads/4.0 - CLOUDSTACK-1265: /etc/init.d/dnsmasq
puts pid in /var/run/dnsmasq/dnsmasq.pid logrotate checks /var/run/dnsmasq.pid
instead and may not send SIGUSR2 to dnsmasq to start writing to the new log
file instead
Posted by Chip Childers <ch...@sungard.com>.
Never mind. I see it now. Sorry for the confusion.
On Thu, Feb 14, 2013 at 9:02 AM, Chip Childers
<ch...@sungard.com> wrote:
> Should this go into 4.1 as well?
>
> On Wed, Feb 13, 2013 at 10:39:07PM +0000, chiradeep@apache.org wrote:
>> Updated Branches:
>> refs/heads/4.0 0be3e0bd6 -> 2dff2a85f
>>
>>
>> CLOUDSTACK-1265: /etc/init.d/dnsmasq puts pid in /var/run/dnsmasq/dnsmasq.pid
>> logrotate checks /var/run/dnsmasq.pid instead and may not send SIGUSR2 to dnsmasq to start writing to the new log file instead
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/2dff2a85
>> Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/2dff2a85
>> Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/2dff2a85
>>
>> Branch: refs/heads/4.0
>> Commit: 2dff2a85f3fee4bde609b93e0a87cf1d003896cd
>> Parents: 0be3e0b
>> Author: Chiradeep Vittal <ch...@apache.org>
>> Authored: Wed Feb 13 14:33:41 2013 -0800
>> Committer: Chiradeep Vittal <ch...@apache.org>
>> Committed: Wed Feb 13 14:39:02 2013 -0800
>>
>> ----------------------------------------------------------------------
>> .../systemvm/debian/config/etc/logrotate.d/dnsmasq | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/2dff2a85/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
>> ----------------------------------------------------------------------
>> diff --git a/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq b/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
>> index f448420..838415d3 100644
>> --- a/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
>> +++ b/patches/systemvm/debian/config/etc/logrotate.d/dnsmasq
>> @@ -6,7 +6,7 @@
>> delaycompress
>> sharedscripts
>> postrotate
>> - [ ! -f /var/run/dnsmasq.pid ] || kill -USR2 `cat /var/run/dnsmasq.pid`
>> + [ ! -f /var/run/dnsmasq/dnsmasq.pid ] || kill -USR2 `cat /var/run/dnsmasq/dnsmasq.pid`
>> endscript
>> create 0640 nobody root
>> }
>>
>>