[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #3219: Use AtomicInteger for index pointers in SeekableByteArrayInputStream

["DomGarguilo (via GitHub)" <gi...@apache.org>]

DomGarguilo commented on code in PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#discussion_r1123325759


##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/SeekableByteArrayInputStream.java:
##########
@@ -42,13 +43,13 @@ public class SeekableByteArrayInputStream extends InputStream {
   @SuppressFBWarnings(value = "VO_VOLATILE_REFERENCE_TO_ARRAY",
       justification = "see explanation above")
   private volatile byte[] buffer;
-  private int cur;
-  private int max;
+  private final AtomicInteger cur;
+  private final AtomicInteger max;

Review Comment:
   I was going off of the comment above these variables describing why `buffer` needs to be volatile and it seems like `max` would fall into the same boat. Both `max` and `buffer` **could** be final as they are both only set in the  constructor however I'm not sure if they should be or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org