You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by takezoe <gi...@git.apache.org> on 2017/06/21 05:54:02 UTC
[GitHub] incubator-predictionio pull request #397: [PIO-69] Add license report genera...
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/397
[PIO-69] Add license report generation using sbt-license-report plugin
`make-licensereport.sh` generates `license-reports/licences-notice.csv` which contains only non-ASL libraries. The result in the latest develop branch is:
```
Common Public License,Common Public License Version 1.0 (http://www.opensource.org/licenses/cpl1.0.txt),junit # junit # 4.11,
GPL,GPL2 w/ CPE (http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # jersey-core # 1.8,
GPL,GPL2 w/ CPE (http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # jersey-core # 1.9,
GPL,GPL2 w/ CPE (http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # jersey-json # 1.8,
GPL,GPL2 w/ CPE (http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # jersey-json # 1.9,
GPL,GPL2 w/ CPE (http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # jersey-server # 1.8,
GPL,GPL2 w/ CPE (http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # jersey-server # 1.9,
GPL,GPL2 w/ CPE (https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html),javax.xml.bind # jaxb-api # 2.2.2,
GPL,GPL2 w/ CPE (https://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.xml.bind # jaxb-impl # 2.2.3-1,
GPL,GPL2 w/ CPE (https://glassfish.java.net/public/CDDL+GPL_1_1.html),org.jvnet.mimepull # mimepull # 1.9.5,
MIT,MIT (https://github.com/softprops/semverfi/blob/0.1.3/LICENSE),me.lessis # semverfi_2.10 # 0.1.3,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),com.github.scopt # scopt_2.10 # 3.5.0,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 1.7.14,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 1.7.18,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 1.7.2,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 1.7.5,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 1.7.7,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-log4j12 # 1.7.18,
MIT,MIT License (http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-log4j12 # 1.7.5,
Mozilla,Mozilla Public License Version 1.1 (http://www.mozilla.org/MPL/MPL-1.1.txt),org.jamon # jamon-runtime # 2.3.1,
Public Domain,Public Domain (http://creativecommons.org/licenses/publicdomain),com.github.stephenc.high-scale-lib # high-scale-lib # 1.1.1,
Public Domain,Public Domain,org.tukaani # xz # 1.0,
unrecognized,none specified (none specified),asm # asm # 3.1,
unrecognized,none specified (none specified),javax.servlet # servlet-api # 2.5,
unrecognized,none specified (none specified),javax.servlet.jsp # jsp-api # 2.1,
unrecognized,none specified (none specified),org.apache.zookeeper # zookeeper # 3.4.6,
unrecognized,none specified (none specified),org.codehaus.jettison # jettison # 1.1,
```
We would able to create a NOTICE file for the binary distribution from this report.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio license-report
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
commit b6c296e1e2eea55cd097388a4b0d8adaab93ffd4
Author: Naoki Takezoe <ta...@apache.org>
Date: 2017-06-21T02:56:21Z
[PIO-69] Add license report generation using sbt-license-report plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #397: [PIO-69] Add license report generation us...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
I added license information for the binary distribution to `LICENSE.txt` and `NOTICE.txt`, but rather it might be nice to create separate files for the binary distribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #397: [PIO-69] Update LICENSE.txt and NOTICE.tx...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
@dszeto I added `tests/check_libraries.sh` to check library dependencies and it's also available on the Travis build. It would be failed when there are any changes in library dependencies. Then we can check the report and update LICENSE.txt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #397: [PIO-69] Add license report generation us...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
I checked the license of all non-ASL libraries and all them can be included as binary form in the distribution. I added their license text to `LICENSE.txt` and updated `make-distribution.sh` to include `LICENSE.txt` and `NOTICE.txt` in the binary distribution.
I think all tasks about 3rd party license is done. Let me know if I have to do something else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #397: [PIO-69] Update LICENSE.txt and NOTICE.tx...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
@dszeto
> We probably need to write a script and put in an exclusion file for those that we have manually verified, and put this check as part of our automated tests.
OK, I will include them in this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #397: [PIO-69] Update LICENSE.txt and NO...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #397: [PIO-69] Update LICENSE.txt and NOTICE.tx...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
@takezoe Excellent work. Thanks! 🎉
I think the only concern left is to make sure whenever we add a new dependency that does not have clear indication of license compatibility, it will be caught automatically. We probably need to write a script and put in an exclusion file for those that we have manually verified, and put this check as part of our automated tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---