[jira] [Closed] (OAK-6637) Release IndexNode lock in finally clause

["Davide Giannella (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davide Giannella closed OAK-6637.
---------------------------------

Bulk close for 1.7.7

> Release IndexNode lock in finally clause
> ----------------------------------------
>
>                 Key: OAK-6637
>                 URL: https://issues.apache.org/jira/browse/OAK-6637
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>              Labels: candidate_oak_1_6
>             Fix For: 1.8, 1.7.7
>
>
> IndexNode currently makes 2 call in release
> {code}
>         @Override
>         public void release() {
>             if (released.compareAndSet(false, true)) {
>                 //Decrement on each release
>                 decrementSearcherUsageCount(holder.searcher);
>                 IndexNodeManager.this.release();
>             }
>         }
> {code}
> Its possible that decrementSearcherUsageCount can throw exception and in that case lock would not be released leading to situation as seen in OAK-6619. 
> As a fix the lock should be released in finally



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)