You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/16 16:14:00 UTC

[jira] [Commented] (PARQUET-1703) Update API compatibility check

    [ https://issues.apache.org/jira/browse/PARQUET-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997425#comment-16997425 ] 

ASF GitHub Bot commented on PARQUET-1703:
-----------------------------------------

gszadovszky commented on pull request #709: PARQUET-1703: Update API compatibility check
URL: https://github.com/apache/parquet-mr/pull/709
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update API compatibility check
> ------------------------------
>
>                 Key: PARQUET-1703
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1703
>             Project: Parquet
>          Issue Type: Task
>            Reporter: Gabor Szadovszky
>            Assignee: Gabor Szadovszky
>            Priority: Major
>              Labels: pull-request-available
>
> The current API compatibility check is comparing the current version of parquet-mr to the release 1.7.0. It is not correct because several changes made in the public API since then which is not verified. Also, many packages are excluded from the check which are part of the public API. The semver plugin is also out of date and not maintained any more. The following tasks are to be done:
> * Find a good tool to check API compatibility
> * Always compare to the previous minor release on master (e.g. 1.11.0 before releasing 1.12.0)
> * Exclude only packages/classes that are clear to not being used by our clients



--
This message was sent by Atlassian Jira
(v8.3.4#803005)