You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/10/03 20:43:28 UTC

[GitHub] [incubator-gobblin] zxcware opened a new pull request #2750: [GOBBLIN-896] Clone schema and field props in AvroSchemaFieldRemover

zxcware opened a new pull request #2750: [GOBBLIN-896] Clone schema and field props in AvroSchemaFieldRemover
URL: https://github.com/apache/incubator-gobblin/pull/2750

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-896

### Description
- [x] Here are some details about my PR:
- Currently, `AvroSchemaFieldRemover` ignores schema and field level properties while cloning the schema and its fields. The change is to fix it.

### Tests
- [x] My PR adds the following unit tests:
- `AvroSchemaFieldRemoverTest.testRemoveFields` covers that props of the schema and field are cloned

### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services