[jira] Issue Comment Edited: (WW-3577) JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance

["Xiaoming Shi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998656#comment-12998656 ] 

Xiaoming Shi edited comment on WW-3577 at 2/24/11 1:42 AM:
-----------------------------------------------------------

Hi Lukasz,

Thanks for your confirmation. 

Similar code can be found in the file

./struts-2.2.1/src/plugins/portlet/src/main/java/org/apache/struts2/portlet/result/PortletVelocityResult.java           line : 179

Could you please have a look at it?

      was (Author: nancyesmis):
    Hi Lukasz,

Thanks for your confirmation. 

Similar code can be found in the file

{noformat}
./struts-2.2.1/src/plugins/portlet/src/main/java/org/apache/struts2/portlet/result/PortletVelocityResult.java           line : 179
{noformat}

Could you please have a look at it?
  
> JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WW-3577
>                 URL: https://issues.apache.org/jira/browse/WW-3577
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.2.1.1
>            Reporter: Xiaoming Shi
>            Assignee: Lukasz Lenart
>             Fix For: 2.2.2
>
>
> JspFactory.getDefaultFactory() is synchronized, we can cache the return value to improve performance.
> In the function doExecute(), 
> ./src/core/src/main/java/org/apache/struts2/dispatcher/VelocityResult.java                  line: 122, 137
> The value returned by JspFactory.getDefaultFactory()  can be cached to reduce race and improve performance
> (Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira