[GitHub] [hive] deniskuzZ commented on a diff in pull request #3559: HIVE-26496,Improvement to fetch operator to scan only delete_delta fo…

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3559:
URL: https://github.com/apache/hive/pull/3559#discussion_r970696749


##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java:
##########
@@ -104,13 +104,32 @@ public OrcSplit(Path path, Object fileId, long offset, long length, String[] hos
     this.isOriginal = isOriginal;
     this.hasBase = hasBase;
     this.rootDir = rootDir;
-    this.deltas.addAll(filterDeltasByBucketId(deltas, AcidUtils.parseBucketId(path)));
+    this.deltas.addAll(filterDeleteDeltasByWriteIds

Review Comment:
   could we transform this construct into a stream pipeline:
   ````
       this.deltas = deltas.stream()
         .filter(delta -> filterDeltasByBucketId(delta, AcidUtils.parseBucketId(path)))
         .filter(delta -> filterDeleteDeltasByWriteIds(delta, conf))
         .collect(Collectors.toList());
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org