[GitHub] [airflow] milton0825 commented on a change in pull request #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

[GitBox <gi...@apache.org>]

milton0825 commented on a change in pull request #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill
URL: https://github.com/apache/airflow/pull/5498#discussion_r298457351
 
 

 ##########
 File path: airflow/jobs/backfill_job.py
 ##########
 @@ -257,31 +258,30 @@ def _manage_executor_state(self, running):
                     ti.handle_failure(msg)
 
     @provide_session
-    def _get_dag_run(self, run_date, session=None):
+    def _get_dag_run(self, run_date: datetime, dag: DAG, session: Session = None):
         """
         Returns a dag run for the given run date, which will be matched to an existing
         dag run if available or create a new dag run otherwise. If the max_active_runs
         limit is reached, this function will return None.
 
         :param run_date: the execution date for the dag run
-        :type run_date: datetime.datetime
+        :param dag: DAG
         :param session: the database session object
-        :type session: sqlalchemy.orm.session.Session
 
 Review comment:
   Ahh that is too bad.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services