You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "yunlongn (via GitHub)" <gi...@apache.org> on 2023/09/05 01:53:08 UTC
[GitHub] [shenyu] yunlongn opened a new pull request, #5115: [type:refactor] Refactor grpc.
yunlongn opened a new pull request, #5115:
URL: https://github.com/apache/shenyu/pull/5115
<!-- Describe your PR here; eg. Fixes #issueNo -->
add shenyu loadbalance. build an instance using selectorId
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5115: [type:refactor] Refactor grpc.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5115:
URL: https://github.com/apache/shenyu/pull/5115#issuecomment-1705867428
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5115](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1682119) into [master](https://app.codecov.io/gh/apache/shenyu/commit/648040c55b3916eac3d15b5f3e495ae3a145e8c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (648040c) will **decrease** coverage by `0.13%`.
> The diff coverage is `40.15%`.
```diff
@@ Coverage Diff @@
## master #5115 +/- ##
============================================
- Coverage 61.82% 61.70% -0.13%
+ Complexity 8498 8496 -2
============================================
Files 1228 1232 +4
Lines 36972 37030 +58
Branches 3515 3517 +2
============================================
- Hits 22859 22848 -11
- Misses 12152 12218 +66
- Partials 1961 1964 +3
```
| [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...u/common/dto/convert/rule/impl/GrpcRuleHandle.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvR3JwY1J1bGVIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ache/shenyu/plugin/grpc/context/GrpcConstants.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2NvbnRleHQvR3JwY0NvbnN0YW50cy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...u/plugin/grpc/loadbalance/picker/ShenyuPicker.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2xvYWRiYWxhbmNlL3BpY2tlci9TaGVueXVQaWNrZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/shenyu/plugin/grpc/GrpcPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL0dycGNQbHVnaW4uamF2YQ==) | `38.88% <20.00%> (-23.12%)` | :arrow_down: |
| [...shenyu/plugin/grpc/loadbalance/SubChannelCopy.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2xvYWRiYWxhbmNlL1N1YkNoYW5uZWxDb3B5LmphdmE=) | `47.82% <20.00%> (-2.18%)` | :arrow_down: |
| [...enyu/plugin/grpc/cache/ApplicationConfigCache.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2NhY2hlL0FwcGxpY2F0aW9uQ29uZmlnQ2FjaGUuamF2YQ==) | `71.05% <60.86%> (-7.90%)` | :arrow_down: |
| [...nyu/plugin/grpc/handler/GrpcPluginDataHandler.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2hhbmRsZXIvR3JwY1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `48.00% <63.63%> (-9.90%)` | :arrow_down: |
| [...n/grpc/loadbalance/ShenyuLoadBalancerProvider.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2xvYWRiYWxhbmNlL1NoZW55dUxvYWRCYWxhbmNlclByb3ZpZGVyLmphdmE=) | `66.66% <66.66%> (ø)` | |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL3Jlc29sdmVyL1NoZW55dU5hbWVSZXNvbHZlci5qYXZh) | `59.74% <66.66%> (+2.29%)` | :arrow_up: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9ncnBjL2NhY2hlL0dycGNDbGllbnRDYWNoZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://app.codecov.io/gh/apache/shenyu/pull/5115?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5115/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yunlongn closed pull request #5115: [type:refactor] Refactor grpc.
Posted by "yunlongn (via GitHub)" <gi...@apache.org>.
yunlongn closed pull request #5115: [type:refactor] Refactor grpc.
URL: https://github.com/apache/shenyu/pull/5115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yunlongn closed pull request #5115: [type:refactor] Refactor grpc.
Posted by "yunlongn (via GitHub)" <gi...@apache.org>.
yunlongn closed pull request #5115: [type:refactor] Refactor grpc.
URL: https://github.com/apache/shenyu/pull/5115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind merged pull request #5115: [type:refactor] Refactor grpc.
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5115:
URL: https://github.com/apache/shenyu/pull/5115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org