You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2015/08/13 23:07:35 UTC
Review Request 37446: Refactor test TestDatabaseProvider.java: make
each
test case independent from other tests, not assume any external states/data
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37446/
-----------------------------------------------------------
Review request for sentry, Anne Yu and Lenni Kuff.
Bugs: SENTRY-836
https://issues.apache.org/jira/browse/SENTRY-836
Repository: sentry
Description
-------
Making sure we clean up after each test. The only setup common to all tests is having an admin user which I just moved it to @BeforeClass
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 9c0958f46fd1250f99c2276ee9009ebd72e58da7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 563ae93fb42ba057e72992efd06a8034b4ac4bc2
Diff: https://reviews.apache.org/r/37446/diff/
Testing
-------
All tests in TestDatabaseProvider pass. Precommit will run the entire suite.
Thanks,
Sravya Tirukkovalur
Re: Review Request 37446: Refactor test TestDatabaseProvider.java:
make each
test case independent from other tests, not assume any external states/data
Posted by Anne Yu <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37446/#review95379
-----------------------------------------------------------
Ship it!
Ship It!
- Anne Yu
On Aug. 13, 2015, 9:07 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37446/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 9:07 p.m.)
>
>
> Review request for sentry, Anne Yu and Lenni Kuff.
>
>
> Bugs: SENTRY-836
> https://issues.apache.org/jira/browse/SENTRY-836
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Making sure we clean up after each test. The only setup common to all tests is having an admin user which I just moved it to @BeforeClass
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 9c0958f46fd1250f99c2276ee9009ebd72e58da7
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 563ae93fb42ba057e72992efd06a8034b4ac4bc2
>
> Diff: https://reviews.apache.org/r/37446/diff/
>
>
> Testing
> -------
>
> All tests in TestDatabaseProvider pass. Precommit will run the entire suite.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>