You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/06 02:22:43 UTC

[GitHub] [helix] dasahcc commented on pull request #1197: Support option to skip direct ZK read for health check API

dasahcc commented on pull request #1197:
URL: https://github.com/apache/helix/pull/1197#issuecomment-669644256


   > One question: Do we want to change these public APIs? Maybe we can use some default value for the skipZKRead so we are not causing backward compatibility issues for existing usages?
   
   @alirezazamani Good question. But for the class itself, they are purely used for REST endpoint, as long as we keep the REST backward compatible, the class we treated as internal.
   
   Different from helix-core, helix-core will be careful since we provided as an library and especially the interfaces under API module should not be changed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org