You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/20 17:19:42 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
donnerpeter opened a new pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
```
aff:
PFX h Y 1
PFX h 0 de .
SFX A Y 1
SFX A te tion/S .
```
dic:
```
hydrate/hA
```
should pass: `assertStemsTo("dehydration", "hydrate");`
# Solution
After the prefix is stripped and there's a suffix to strip, its condition flag may be present not only on the suffix, but also on the stem.
# Tests
A synthetic test based on Spanish `deshidratación`
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764467480
Since it's an actual bug fix, add a separate changes entry under the right section? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764612774
I've filed https://issues.apache.org/jira/browse/LUCENE-9687 and will add my issues there.
Anything else in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764590796
"Hunspell improvements" sounds great to me. You could even collect all the issues you've created so far and convert them to sub-tasks of that parent. (I think you should be able to do it; if not, let me know and I'll do it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764615352
Nope, I think it looks good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764587107
I thought about it too. I think a nicer way to do it would be to create one umbrella (parent) jira issue and sub-issues or sub-tasks which you could then create pull requests against. Or even skip sub-issues and just reference the parent directly from multiple PRs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764585332
> Since it's an actual bug fix, add a separate changes entry under the right section? :)
I can but I'm not sure that'll be necessary. In the end, I imagine `CHANGES.txt` having just one entry like "LUCENE-XXXX *(maybe many issues)*: Hunspell: introduce SpellChecker API, fully English, Spanish, French, *whatever else* dictionaries", where this change would nicely fall into Spanish section. This should summarize the changes pretty well, and wouldn't overburden the readers with too much detail. Does this make sense to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764585332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764589943
The umbrella issue idea looks good, I can file one. Is "Hunspell SpellChecker API" or "Hunspell improvements" a good name?
As for skipping sub-issues, I'd be fine with that, but Robert Muir preferred them: http://mail-archives.apache.org/mod_mbox/lucene-dev/202101.mbox/%3CCAOdYfZXo-z5sy7LG_VCAQ-qj2_tM41sNw2E6ZzEDivwaDmDJDw%40mail.gmail.com%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-763804430
Reviewing commits separately might be easier. Committing them separately might make sense (not so sure about that)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226#issuecomment-764467480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2226: LUCENE-9685: Hunspell: prefix condition is only checked on suffix, not stem
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2226:
URL: https://github.com/apache/lucene-solr/pull/2226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org