[GitHub] [airflow] ashb commented on a change in pull request #5543: Fix permission error when creating logs

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5543: Fix permission error when creating logs
URL: https://github.com/apache/airflow/pull/5543#discussion_r302473929
 
 

 ##########
 File path: airflow/utils/log/file_processor_handler.py
 ##########
 @@ -84,7 +84,7 @@ def close(self):
             self.handler.close()
 
     def _render_filename(self, filename):
-        filename = os.path.relpath(filename, self.dag_dir)
+        filename = os.path.relpath(filename, self.dag_dir).replace("../", "")
 
 Review comment:
   This doesn't seem like the right fix as it will change the path. Using something like `os.path.abspath` might be the way to go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services