You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "christophd (via GitHub)" <gi...@apache.org> on 2023/05/24 12:46:35 UTC

[GitHub] [camel-k] christophd opened a new pull request, #4411: chore: Improve Camel dependency validation

christophd opened a new pull request, #4411:
URL: https://github.com/apache/camel-k/pull/4411

   - Reuse logic in validate function just logging a warning and those validate function raising errors
   - Remove unused function ValidateDependencies
   - Add some unit tests
   - Add some documentation on Camel dependency resolution via catalog
   
   Successor PR to #4402 
   
   Basically keeps the old logic of throwing errors when a dependency is not in the Camel catalog but adds some new unit tests and some improvements on the dependency validation functions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on pull request #4411: chore: Improve Camel dependency validation

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4411:
URL: https://github.com/apache/camel-k/pull/4411#issuecomment-1562411092

   > @squakez I think there has been an issue with the validate workflow recently? should I rebase?
   
   No worries, I am merging it anyway and it will rebased automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] christophd commented on pull request #4411: chore: Improve Camel dependency validation

Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #4411:
URL: https://github.com/apache/camel-k/pull/4411#issuecomment-1562364370

   @squakez I think there has been an issue with the validate workflow recently? should I rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on pull request #4411: chore: Improve Camel dependency validation

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4411:
URL: https://github.com/apache/camel-k/pull/4411#issuecomment-1562411705

   BTW, if we can backport to 1.12 branch then I will start the release process accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez merged pull request #4411: chore: Improve Camel dependency validation

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4411:
URL: https://github.com/apache/camel-k/pull/4411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org